Sling
  1. Sling
  2. SLING-1596

Reduce coupling between RequestData and SlingHttpServletRequestImpl

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: Engine 2.0.6
    • Fix Version/s: None
    • Component/s: Engine
    • Labels:
      None

      Description

      As discussed in http://markmail.org/thread/ldayz27ehldyvzr4 the tight coupling between RequestData and SlingHttpServletRequestImpl makes it impossible to use request classes that just implement SlingHttpServletRequest.

      I need this for example for SLING-550, where servlets run outside of the container's request/response cycle.

      I'll attach a patch that reduces coupling by grabbing the RequestData from a request attribute instead of relying on the SlingHttpServletRequestImpl class to provide it. All tests including integration pass with this patch.

      1. SLING-1596.patch
        4 kB
        Bertrand Delacretaz

        Issue Links

          Activity

          No work has yet been logged on this issue.

            People

            • Assignee:
              Bertrand Delacretaz
              Reporter:
              Bertrand Delacretaz
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Development