[SLING-11496] Fresh instance must remain suppressed until syncToken stored

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Discovery Oak 1.2.36
• Fix Version/s: Discovery Oak 1.2.40
• Component/s: Discovery
• Assignee: Stefan Egli
• Reporter: Stefan Egli
• Created: 25/Jul/22 14:09
• Updated: 03/Aug/22 09:48
• Resolved: 26/Jul/22 14:27

Description

The changes in SLING-11450 have one case still missing : if an instance reuses the clusterNodeId but is slow, it is not suppressed. Reason being that there's no cleanup of data in /var/discovery/oak/idMap and ./clusterInstances. So if it reuses the clusterNodeId, the old data from a previous instance would still be there, and the other instances do not distinguish where the data originated.

The only way to detect a clusterNodeId-reuse is to require it to update the syncToken. Until it doesn't do that it is suppressed. Once it does it, it joins the cluster regularly. From then on, then syncToken is no longer checked (since existing instances are excempted from that check).