Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-10742

Create integration tests for ResourceResolver

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: Resource Resolver 1.7.10
    • Fix Version/s: None
    • Component/s: ResourceResolver
    • Labels:
      None

      Description

      Now that the logic in Resource Resolver becomes more and more complex, for example with regards to executing querys, it would be a good idea to create some integration tests for this module.

      Mocking frameworks only go so far, many assumptions are made. In particular, query execution is not done in our mocking frameworks. Instead of executing them, we're basically saying "If we receive query 'x', we return results [y, z]", without validating the query, without parsing it, without executing it.

      This came up in SLING-10447, where we decided that verifying the correct execution of the querys would be valuable to have. Right now, only the string (that contains the query) is checked, but we're not checking if there are any syntax issues and we're also not checking if the query executes correctly, i.e. returns the expected results.

      We will probably come up with some more complex logic in SLING-10466, which could also benefit from these integration tests.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              Henry Kuijpers Henry Kuijpers
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: