[SLING-10707] Comma in selector not correctly escaped in capability header

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Scripting Bundle Maven Plugin 0.3.0
• Fix Version/s: Scripting Bundle Maven Plugin 0.4.0
• Component/s: Maven Plugins and Archetypes
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 06/Aug/21 14:54
• Updated: 21/Sep/21 16:33
• Resolved: 23/Aug/21 07:02

Description

The manual escaping in https://github.com/apache/sling-scriptingbundle-maven-plugin/blob/master/src/main/java/org/apache/sling/scriptingbundle/plugin/capability/Capabilities.java is not enough for list items containing a comma.

According to http://docs.osgi.org/specification/osgi.core/7.0.0/framework.module.html#i3306043

Commas or reverse solidi ('\' \u005C) that are part of an element value must be escaped by prefixing them with a reverse solidus. In practice, this requires escaping with two reverse solidi because a reverse solidus must already be escaped in strings.

Instead of doing the escaping manually (and always use quoted strings) I would rather leverage aQute.bnd.header.OSGiHeader

Issue Links

• relates to: SLING-7516 ResourceRuntimeExtension: Selectors containing a comma are not treated correctly
• links to: GitHub Pull Request #5