Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-10584

Warn if an invocation of a BindingsValuesProvider takes long

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • Scripting Core 2.3.6
    • Scripting Core 2.4.0
    • Scripting
    • None

    Description

      While analyzing a performance problem it took me quite a while to find out that the addBindings method of a specific BindingsValuesProvider took a significant amount of time, especially because this method was invoked quite often (many JSP snippets were included during the rendering).

      When the bindings are added, there should be an INFO log message if a BindingsValuesProvider takes more than 1msec to provide the bindings.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            joerghoh Joerg Hoh
            joerghoh Joerg Hoh
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 3.5h
                3.5h

                Slack

                  Issue deployment