[SLING-10269] cache results of isResourceType()

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Resource Resolver 1.7.2
• Fix Version/s: Resource Resolver 1.7.4
• Component/s: ResourceResolver
• Assignee: Joerg Hoh
• Reporter: Joerg Hoh
• Created: 31/Mar/21 06:46
• Updated: 15/Apr/21 21:46
• Resolved: 09/Apr/21 14:46

Description

I have code, which uses

resourceResolver.isResourceType(Resource, String)

very often to determine type information. I also observed, that the execution time of this method contributes a lot to the overall execution time.

Also the number of unique resourcetypes which are going to be checked (resource.getResourceType, 1st parameter) is typically quite low; the same applies for the number of resourcetypes it is compared against. So it makes sense to cache the result of that method call in map which shares the lifetime of the ResourceResolver, as the result will never change during this lifetime. But during a refresh() or commit() this map can be cleared, so any changes in the RT hierarchy which might have happened will get effective.

I have tested this approach already and it gives a significant speedup to my code (reduced execution time by 50%); of course this cannot be expected universally, as this is an extreme case, but it shows that there is indeed a bit of overhead.

https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/43

Issue Links

• relates to: SLING-10276 javadoc: add statement about modifications outside of Sling resource API