[SLING-10236] Introduce Operation.asRepoInitString

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Repoinit Parser 1.6.6
• Fix Version/s: Repoinit Parser 1.6.8
• Component/s: Repoinit
• Assignee: Bertrand Delacretaz
• Reporter: Angela Schreiber
• Created: 18/Mar/21 09:40
• Updated: 01/May/21 09:32
• Resolved: 30/Mar/21 13:27

Description

for SLING-10219 (and maybe other use cases too) it would be great if org.apache.sling.repoinit.parser.operations.Operation would come with a asRepoInitString method that would allow to obtain the original repo-init statements.

I was checking if toString would allow to extract that (with a bit of extra effort) but unfortunately the default implementation is:

    public String toString() {
        return this.getClass().getSimpleName() + " " + this.getParametersDescription();
    }

and getParametersDescription isn't implemented in a consistent way and in some cases doesn't reveal all information needed.
further more even the toString method isn't consistent across the various operation implementations (e.g. RegisterPrivilege.toString actually coming close to the original statement and not including the simple class name)

Issue Links

• is required by: SLING-10268 Use Operation.asRepoInitString instead of hardcoding repo-init statements
• relates to: SLING-10219 Expand enforcing principal-based authorization option to repo-init