[SLING-10224] Feature-Launcher: only embed a minimal set of apache-commons classes

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Feature Model Launcher 1.1.16
• Fix Version/s: Feature Model Launcher 1.1.18
• Component/s: Feature Model
• Assignee: Bertrand Delacretaz
• Reporter: Stefan Bischof
• Created: 16/Mar/21 18:48
• Updated: 18/Mar/21 14:57
• Resolved: 18/Mar/21 14:57

Description

StringSubstitutor from commons-text is a great Util to replace '${thisVar}' with something. In the SlingFeatureLauncher case it replaces placeholder with the value of the map`context.getFrameworkProperties()` , or an empty string.

But commons-lang3 and commons-text brings 600kb to the Bundle.

Maybe we can Substitute it with a more lightweight StringSubstitutor.

Update: as discussed below, embedding just the required apache-commons classes has the same effect, without having to rewrite code

Issue Links

• links to: GitHub Pull Request #20
• links to: GitHub Pull Request #22