[SLING-10107] Refactoring of creation of ResourceResolvers

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: Content Distribution Journal Core 0.1.16
• Component/s: Content Distribution
• Assignee: Unassigned
• Reporter: Joerg Hoh
• Created: 30/Jan/21 15:43
• Updated: 15/Mar/23 13:10

Description

In the 2 classes Bookkepper and the Localstore the creation of ResourceResolvers is spread over multiple places, and also the number of methods, where ResourceResolvers are opened for obviously tiny operations is quite high.

Therefor I refactored the creation of ResourceResolvers for the subservice bookkeeper (which is the majority of cases) and centralized the creation of it into a central supplier within the Bookkeeper. I also added a new Gauge metric to observe how often a new ResourceResolver is actually created.

My gut feeling is, that the number of creations is (too) high; but before I start combining operations and reduce the number of ResourceResolver creations, I would like to understand if it's a problem at all.

See https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/63 for the PR

Issue Links

• links to: GitHub Pull Request #63