Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-10073

ErrorHandlingTest.test_errorhandling_POST_operation_SlingPostServlet fails after SLING-10006

    XMLWordPrintableJSON

Details

    Description

      After SLING-10006 the Sling ITs fail with

      [ERROR] Failures: 
      [ERROR]   ErrorHandlingTest.test_errorhandling_POST_operation_SlingPostServlet:177->assertWithRetries:97->RenderingTestBase.assertContains:36 Content does not contain 'Exception thrown - custom error page' (content=<!--
      /*
       * Licensed to the Apache Software Foundation (ASF) under one
       * or more contributor license agreements.  See the NOTICE file
       * distributed with this work for additional information
       * regarding copyright ownership.  The ASF licenses this file
       * to you under the Apache License, Version 2.0 (the
       * "License"); you may not use this file except in compliance
       * with the License.  You may obtain a copy of the License at
       *
       *   http://www.apache.org/licenses/LICENSE-2.0
       *
       * Unless required by applicable law or agreed to in writing,
       * software distributed under the License is distributed on an
       * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       * KIND, either express or implied.  See the License for the
       * specific language governing permissions and limitations
       * under the License.
      -->
      <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
      <!-- simple JSP rendering test -->
      
      
      
      <html>
      	<head>
      		<title>500 Internal Server Error</title>
      	</head>
      	<body>
      		<h1>Internal Server Error (500) - custom error page</h1>
      	</body>
      </html>)

      Looks like the error handling behaviour has changed in an incompatible manner.

      To reproduce, update to the latest servlets.post in the Sling Starter:

      diff --git a/src/main/features/base.json b/src/main/features/base.json
      index 754bf13..f2eb6cf 100644
      --- a/src/main/features/base.json
      +++ b/src/main/features/base.json
      @@ -110,7 +110,7 @@
                   "start-order":"20"
               },
               {
      -            "id":"org.apache.sling:org.apache.sling.servlets.post:2.3.36",
      +            "id":"org.apache.sling:org.apache.sling.servlets.post:2.4.2",
                   "start-order":"20"
               },
               {
      

      Attachments

        Issue Links

          Activity

            People

              enorman Eric Norman
              rombert Robert Munteanu
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: