[SLIDER-778] Clean up AgentProviderService slightly

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Slider 0.70
• Fix Version/s: Slider 0.70
• Component/s: agent-provider
• Sprint: Slider Jan #2
• Assignee: Steve Loughran
• Reporter: Steve Loughran
• Created: 06/Feb/15 15:58
• Updated: 06/Feb/15 17:42
• Resolved: 06/Feb/15 17:42

Description

Clean up the agent provider slightly

1. do some IDE logging improvements hints
2. factor out a recurrent check of maps & lists being non-null & non-empty
3. replace the (inefficient) getClusterState->getClusterNodes logic with something which achieves the same goals with less structures being built per call