Details
-
Bug
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
Slider 0.91
-
None
Description
Following possible null pointer dereferences found in the code needs to be fixed.
slider-core/src/main/java/org/apache/slider/server/appmaster/state/AppState.java
819 ProviderRole dynamicRole = createDynamicProviderRole(newName, name, component);
dereference: Dereferencing a pointer that might be null component when calling createDynamicProviderRole
836 roleHistory.addNewRole(roleStatus);
null_method_call: Calling a method on null object roleHistory
1290 return roleHistory.requestContainerForRole(role).getIssuedRequest();
null_method_call: Calling a method on null object roleHistory.requestContainerForRole(role)
slider-core/src/main/java/org/apache/slider/client/SliderClient.java
960 char[] newPassword2 = br.readLine().toCharArray();
null_method_call: Calling a method on null object br.readLine()
3679 Path subPath = new Path(path1, appReport.getApplicationId().toString() 3680 + "/agent");
null_method_call: Calling a method on null object appReport.
3795 Path subPath = new Path(path1, appReport.getApplicationId().toString() 3796 + "/agent"); 3797 imagePath = subPath.toString();
null_method_call: Calling a method on null object appReport.
slider-core/src/main/java/org/apache/slider/common/tools/SliderUtils.java
1035 return !(address.getHostString().equals("0.0.0.0"));
null_method_call: Calling a method on null object address.getHostString()
1422 for (String entry : confDirEntries) {
null_array_length: Accessing length of null array confDirEntries
slider-core/src/main/java/org/apache/slider/common/tools/CoreFileSystem.java
682 Path[] localFilePaths = new Path[localFiles.length];
null_array_length: Accessing length of null array localFiles
slider-core/src/main/java/org/apache/slider/server/services/security/FsDelegationTokenManager.java
159 tokenExpiryTime = CredentialUtils.getTokenExpiryTime(token);
dereference: Dereferencing a pointer that might be null token when calling getTokenExpiryTime
237 currentUser.addToken(token.getService(), token);
null_method_call: Calling a method on null object token
slider-core/src/main/java/org/apache/slider/server/appmaster/rpc/SliderIPCService.java
237 result = cd.toJsonString();
null_method_call: Calling a method on null object cd
slider-core/src/main/java/org/apache/slider/server/appmaster/actions/RenewingAction.java
66 Preconditions.checkArgument(action != null, "null actions");
check_after_deref: Null-checking action suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
slider-core/src/main/java/org/apache/slider/core/launch/SerializedApplicationReport.java
70 this.applicationAttemptId = report.getCurrentApplicationAttemptId().toString();
null_method_call: Calling a method on null object report.getCurrentApplicationAttemptId()