Uploaded image for project: 'Slider'
  1. Slider
  2. SLIDER-1005

The java code generated by protobuf should not be placed in src directory

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • Slider 0.90.2
    • Slider 1.0.0
    • build, core
    • None
    • Centos 6.5, Maven 3.2.5

    Description

      Now slider using protobuf for RPC, but the output directory is <output>${basedir}/src/main/java</output> in slider-core/pom.xml. That means the generated java code was been placed in the src directory.
      I have seen the generated java code for protobuf in Hadoop, they put the code in build directory <output>${project.build.directory}/generated-sources/java</output>. And they put the compile-protoc in <plugin> not <profile> in the pom.xml.
      I think the way Hadoop used is more reasonable. The code is generated by protobuf, not by ourselves.

      Attachments

        1. SLIDER-1005-001.patch
          1.33 MB
          Pan Yuxuan

        Activity

          People

            panyuxuan Pan Yuxuan
            panyuxuan Pan Yuxuan
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: