Details
-
Bug
-
Status: Closed
-
Trivial
-
Resolution: Fixed
-
0.3
-
None
Description
Execution of mvn -Papache-release produces a sis-0.3-incubating-SNAPSHOT-source-release.zip file containing all the project directory with the addition of the following files, which seem auto-generated:
- LICENSE
- NOTICE
- DEPENDENCIES
The LICENSE and NOTICE files are strictly identical to the LICENSE.txt and NOTICE.txt files at the root of the project directory, except for the notice header:
Apache Spatial Information System (SIS) Copyright 2010 The Apache Software Foundation
Apache SIS Copyright 2010-2012 The Apache Software Foundation
The DEPENDENCIES file does not exist in the SVN checkout. There is no GPG signatures or MD5 checksums, but it may be (at least for GPG) because I do not have the necessary keys.
This result is a file duplication, since the ZIP file contains all of LICENSE, LICENSE.txt, NOTICE and NOTICE.txt files. The http://apache.org/dev/apply-license.html#new page gives me the feeling that we are supposed to use LICENSE and NOTICE filenames without ".txt" extension. My guess is that the plugin was looking for a NOTICE file, didn't found it, and consequently generated a default one. The fact that the auto-generated NOTICE file may be wrong (since it can not contain the project-specific notices) enforces my feeling that this plugin behaviour is just a fallback when no NOTICE file has been found in the project.
The proposed action is to rename NOTICE.txt to NOTICE and LICENSE.txt to LICENSE in the project root directory. The assembly plugin then pickup our files instead than generating default ones.
Whatever we should also remove the ".txt" extension in CHANGES.txt, HEADER.txt and README.txt for consistency is an open question.
