Uploaded image for project: 'Spatial Information Systems'
  1. Spatial Information Systems
  2. SIS-560

Remove the boolean return value in WritableFeatureSet.removeIf(Predicate)

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.0, 1.1, 1.2
    • 1.4
    • Storage
    • None

    Description

      org.apache.sis.storage.WritableFeatureSet currently contains the following method:

      boolean removeIf(Predicate<? super Feature> filter) throws DataStoreException;
      

      The boolean return type may need to be removed. It currently exists for compatibility with the Collection.removeIf(Predicate) method in case an implementation chooses to implement WritableFeatureSet and java.util.Collection in same time. But this is not recommended, and the current method signature is a blocker for deferred method execution. Telling if there is any feature to remove requires immediate execution of the filter, while an implementation may want to wait in case the filtering can be combined with other operations such as add(…) or replaceIf(…).

      Attachments

        Activity

          People

            desruisseaux Martin Desruisseaux
            desruisseaux Martin Desruisseaux
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: