Uploaded image for project: 'Singa'
  1. Singa
  2. SINGA-488

Travis CI always build from Apache master branch

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Component/s: None
    • Labels:
      None
    • Flags:
      Important

      Description

      It seems that the Travis build always use the master branch from github.com/apache/incubator-singa.git instead of building the pull request.

      When checking the job log of Travis, I found it reads from github two times:

      1. In the first time, it reads the correct pull request: (for example Pull Request 532)

      git clone --depth=50 https://github.com/apache/incubator-singa.git apache/incubator-singa
      ...
      git fetch origin +refs/pull/532/merge:
      git checkout -qf FETCH_HEAD
      

      2. Then it ignores this correctly fetched code, and does another git clone from the conda build script:

      Cloning into bare repository '/home/travis/conda-bld-1594.2/git_cache/github.com/apache/incubator-singa.git'...
      ...
      Your branch is up to date with 'origin/master'.
      

      This means that it always builds the master branch instead of building the pull request. So it has two problems:

      1. Missed alarms: if the master branch builds successfully, this will be shown as if the pull request is fine and can be merged. While the pull request code was actually never built.
      2. False alarms: if the master branch does not build successfully, this will be shown as if the pull request has a problem, even if the problem is actually in the master branch not in the pull request.

      If this issue is correct, then this is a blocker issue and I suggest to resolve it before creating or merging any pull request. Because the continuous integration tools that is supposed to test the pull requests is not working correctly.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                moazreyad Moaz Reyad
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m