Shiro
  1. Shiro
  2. SHIRO-85

ShiroFilter entries being processed in arbitrary order

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 0.9
    • Component/s: Configuration
    • Labels:
      None

      Description

      Copied over from the Ki issue. Original text:

      Entries in a ShiroFilter configuration are not being processed in the order they are listed in.
      If we have these lines:
      sessionManager=org.apache.shiro.web.session.DefaultWebSessionManager
      securityManager.sessionManager = $sessionManager
      securityManager.sessionDAO = $sessionDAO
      ...and line 3 is processed before line 2, the setSessionManager() call for the first line fails because the sessionManager is a ServletContainerSessionManager rather than a DefaultWebSessionManager.

      In ReflectionBuilder.buildObjects(), instanceMap and propertyMap need
      to be LinkedHashMap type, not just HashMap. With HashMap, the
      properties in ShiroFilter are being processed in arbitrary order,
      rather than the order listed.

      See the "need more help with SSO" thread in the Shiro mailing list:
      http://mail-archives.apache.org/mod_mbox/incubator-shiro-user/200908.mbox/browser

        Activity

        Andy Tripp created issue -
        Hide
        Les Hazlewood added a comment -

        Fix committed to SVN rev. 806298

        Show
        Les Hazlewood added a comment - Fix committed to SVN rev. 806298
        Les Hazlewood made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Les Hazlewood added a comment -

        Closing all resolved issues due to a successful 1.0.0-incubating release

        Show
        Les Hazlewood added a comment - Closing all resolved issues due to a successful 1.0.0-incubating release
        Les Hazlewood made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Les Hazlewood
            Reporter:
            Andy Tripp
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development