Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Consider following code (used in JUnit test):

      Subject currentUser = SecurityUtils.getSubject();
      //login as user with some permissions
      currentUser.login(new UsernamePasswordToken("empl1", "pass1"));
      //call some protected function
      currentUser.logout();
      // now use user without required premissions
      currentUser.login(new UsernamePasswordToken("testUser", "blah"));
      //call protected method - should throw UnaauthorizedException

      This code looks ok, but it will not work. It will throw NPE on the line with second login() call.
      This is beacuse logout() method will clear the securityManager field in currentUser object, and the next login() call will call the method on this securityManager, rising NPE.

      It would be better if we allow somehow for such scenario - open question is how? At this moment the currentUser object after logout() method becomes completely useless.

      (Current workaround: after calling logout() and before second call to login() you have to replace currentUser object:
      currentUser = SecurityUtils.getSubject();

        Activity

        Hide
        Les Hazlewood added a comment -

        Fixed with accompanying unit test. Subject can login/logout as many times as desired, and JavaDoc was updated to reflect this. Also see the DefaultSecurityManagerTest.testSubjectReuseAfterLogout() unit test for verification.

        Show
        Les Hazlewood added a comment - Fixed with accompanying unit test. Subject can login/logout as many times as desired, and JavaDoc was updated to reflect this. Also see the DefaultSecurityManagerTest.testSubjectReuseAfterLogout() unit test for verification.
        Hide
        Les Hazlewood added a comment -

        Closing all resolved issues due to a successful 1.0.0-incubating release

        Show
        Les Hazlewood added a comment - Closing all resolved issues due to a successful 1.0.0-incubating release

          People

          • Assignee:
            Les Hazlewood
            Reporter:
            Grzegorz Borkowski
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development