Shiro
  1. Shiro
  2. SHIRO-79

PathConfigProcessor.processPathConfig() should return Filter

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Currently return type of PathConfigProcessor.processPathConfig() is void. Would be nice if it returned a Filter instead to make configuring jsecurity in all-java easier, so you could for example write filters.add(pathMatchingFilter.processPathConfig(path, filterConfig)). It would also open up other interesting possibilities for filter implementations (delegating proxy filters etc.). The change is fully backwards compatible and simple, see patch.

      1. JSEC-61.patch
        2 kB
        Kalle Korhonen

        Activity

        Hide
        Les Hazlewood added a comment -

        Closing all resolved issues due to a successful 1.0.0-incubating release

        Show
        Les Hazlewood added a comment - Closing all resolved issues due to a successful 1.0.0-incubating release
        Hide
        Jeremy Haile added a comment -

        Kalle - applied change as you suggested.

        Show
        Jeremy Haile added a comment - Kalle - applied change as you suggested.
        Hide
        Kalle Korhonen added a comment -

        Change signature of PathMatchingFilter.processPathConfig to return Filter.

        Show
        Kalle Korhonen added a comment - Change signature of PathMatchingFilter.processPathConfig to return Filter.

          People

          • Assignee:
            Unassigned
            Reporter:
            Kalle Korhonen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development