Uploaded image for project: 'Shiro'
  1. Shiro
  2. SHIRO-668

Catch unexpected errors which can lead to oom

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Resolved
    • Affects Version/s: None
    • Fix Version/s: 1.5.0
    • Component/s: None
    • Labels:
      None

      Description

      Unexpected errors in the "run" method of the validation ExecutorServiceSessionValidationScheduler can kill the validation thread an it will not be executed anymore (see [StackOverflow](https://stackoverflow.com/questions/6494557/why-does-a-scheduledexecutorservice-not-run-a-task-again-after-an-exception-is-t).) This can lead to OOM's through too much sessions and can be a security risk by never ending sessions.
      Catching "Throwable" is not the cleanest solution but it garant that the thread will be executed in the future.

        Attachments

          Activity

            People

            • Assignee:
              fpapon Francois Papon
              Reporter:
              fpapon Francois Papon
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 3h 10m
                3h 10m