[SHIRO-564] WildcardPermission case-insensitive makes parts collections twice

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.2.4
• Fix Version/s: 1.3.0
• Component/s: Authorization (access control)
• Environment: Any
• Assignee: Unassigned
• Reporter: Matt Bishop
• Created: 21/Mar/16 19:08
• Updated: 29/Jun/16 22:26
• Resolved: 29/Jun/16 22:26

Description

WildcardPermissions have a caseSensitive flag that instructs the permission to ignore case when comparing permissions. It's implementation of this feature is kinda wasteful because it first parses the permission string into a Set<String> part, THEN checks the flag and then rebuilds the part Set.

It might be faster to check the flag first, lowercase the permission string, then parse the parts. This would save creating a whole bunch of extra LinkedHashSets.

Issue Links

• links to: GitHub Pull Request #18