[SHIRO-498] ThreadLocal should not be created when not necessary

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.2
• Fix Version/s: 1.2.4
• Labels: patch
• Assignee: Unassigned
• Reporter: Jochen Kemnade
• Created: 30/Apr/14 14:05
• Updated: 15/Jul/16 15:15
• Resolved: 12/Apr/15 03:12

Description

org.apache.shiro.util.ThreadContext.getValue(Object) and org.apache.shiro.util.ThreadContext.remove(Object) initialze the TheadLocal unnecessarily via initialValue(). Both methods should return without creating the ThreadLocal to avoid potential memory leaks.

Issue Links

• relates to: SHIRO-159 ThreadLocal is not cleared upon the unloading of the webapp and the SHiro Servlet