[SHIRO-455] Allowing to cache WildcardPermission in WildcardPermissionResolver class

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.2.1, 1.2.2
• Component/s: Authorization (access control) , Caching
• Labels: features patch
• Assignee: Unassigned
• Reporter: Thibault Tigeon
• Created: 31/Jul/13 15:31
• Updated: 23/Jun/16 23:11

Description

Hello,

I am benching Shiro, tahnks this method:
public void bench() {
final Subject subject = SecurityUtils.getSubject();
subject.login(new UsernamePasswordToken(LOGIN+i, PWD));
for (int ind = 0; ind < 100000; ind++)

{ // a lot of authorizations assertTrue(subject.isPermitted("medias:album:read")); }

subject.logout();
}

I see that I waste my time in the methode WildCardPermissionResolver which create a new instance of permission each time even if it is the same String in parameter.
I added a map which allows to cache WildcardPermission.
You can find in attachement the patch.

PS : the cache for authorisation is activated:
cacheManager = org.apache.shiro.cache.MemoryConstrainedCacheManager
securityManager.cacheManager = $cacheManager

Regards,

Thibault