Uploaded image for project: 'Shiro'
  1. Shiro
  2. SHIRO-429

perms filter parsing is too sensitive to a trailing space

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.2.1
    • Fix Version/s: 1.2.2
    • Component/s: Configuration
    • Labels:
      None

      Description

      I have a filter definition similar to:

      /some/url/** = someFilter, anotherFilter, perms["perm1", "perm2"]

      The above does not work – the parser concatenates perm1 and perm2 into one permission, and therefore denies the request.

      The "fix" is to add a space before the trailing "]" i.e.:

      /some/url/** = someFilter, anotherFilter, perms["perm1", "perm2" ]

      This then works fine. Ouch!

      As an aside, the trace level logging logs all sorts of stuff to the logs, but fails to log anything from the perms filter explaining why the request was being denied. This is weird, to say the least.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              rocketraman Raman Gupta
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: