Shiro
  1. Shiro
  2. SHIRO-353

DefaultSecurityManager has invalid SLF4J log instruction

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.1, 1.3.0
    • Component/s: None
    • Labels:
      None

      Description

      Invalid SLF4J message (string concatenation with {} inside template) in DefaultSecurityManager class.

      Line 550:

      log.debug("Logging out subject with primary principal {}" + principals.getPrimaryPrincipal());

      Should be:

      log.debug("Logging out subject with primary principal {}", principals.getPrimaryPrincipal());

        Activity

        Les Hazlewood made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Les Hazlewood added a comment -

        Closing per the 1.2.1 release.

        Show
        Les Hazlewood added a comment - Closing per the 1.2.1 release.
        Les Hazlewood made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.2.1 [ 12319511 ]
        Fix Version/s 1.3.0 [ 12317961 ]
        Resolution Fixed [ 1 ]
        Hide
        Les Hazlewood added a comment -

        The bug was still in the 1.2.x branch. Fixed in both the branch and the trunk.

        Show
        Les Hazlewood added a comment - The bug was still in the 1.2.x branch. Fixed in both the branch and the trunk.
        Hide
        Les Hazlewood added a comment -

        Line 550 in trunk already represents the recommended change. What code did you check this against?

        Show
        Les Hazlewood added a comment - Line 550 in trunk already represents the recommended change. What code did you check this against?
        Maciej Ziarko made changes -
        Field Original Value New Value
        Description Invalid SLF4J message (string concatenation with {} inside template)

        Line 550:

        log.debug("Logging out subject with primary principal {}" + principals.getPrimaryPrincipal());

        Should be:

        log.debug("Logging out subject with primary principal {}", principals.getPrimaryPrincipal());
        Invalid SLF4J message (string concatenation with {} inside template) in DefaultSecurityManager class.

        Line 550:

        log.debug("Logging out subject with primary principal {}" + principals.getPrimaryPrincipal());

        Should be:

        log.debug("Logging out subject with primary principal {}", principals.getPrimaryPrincipal());
        Maciej Ziarko created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Maciej Ziarko
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2m
              2m
              Remaining:
              Remaining Estimate - 2m
              2m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development