Shiro
  1. Shiro
  2. SHIRO-316

Annotations in samples-aspectj Project Does not Work

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.2, 1.3.0
    • Component/s: Sample Apps
    • Labels:
      None

      Description

      @RequiresPermissions annotations in samples-aspectj project are ignored. It has two reasons:
      1.) shiro-aspectj: aspectj-maven-plugin in complains about aspectjrt version. Maven downloaded 1.6.9 while plugin requires 1.6.7.
      2.) samples-aspectj: aspectj-maven-plugin has only test-compile goal. Compile goal is missing.

        Activity

        Hide
        Maria Jurcovicova added a comment -

        Patch changes two projects:

        Project samples-aspectj

        • Added testCloseAccount_unauthorizedAttempt to test whether annotations works.
        • Minor fix in shiroBankServiceTest.ini (missing comma).
        • Added goal compile to aspectj-maven-plugin.

        Project shiro-aspectj

        • Specified version 1.6.7 for aspectjrt and aspectjweaver dependencies.
        Show
        Maria Jurcovicova added a comment - Patch changes two projects: Project samples-aspectj Added testCloseAccount_unauthorizedAttempt to test whether annotations works. Minor fix in shiroBankServiceTest.ini (missing comma). Added goal compile to aspectj-maven-plugin. Project shiro-aspectj Specified version 1.6.7 for aspectjrt and aspectjweaver dependencies.
        Hide
        Les Hazlewood added a comment -

        Kalle,

        Any objections to me applying this?

        Cheers,

        Les

        Show
        Les Hazlewood added a comment - Kalle, Any objections to me applying this? Cheers, Les
        Hide
        Nicolas Georges added a comment -

        It would be nice if the patch could be applyed in the release, it take me lot of time to figure out what was wrong before to found this patch.

        Show
        Nicolas Georges added a comment - It would be nice if the patch could be applyed in the release, it take me lot of time to figure out what was wrong before to found this patch.
        Hide
        Les Hazlewood added a comment -

        applied patch but upgraded the aspectj-maven-plugin to version 1.4

        Show
        Les Hazlewood added a comment - applied patch but upgraded the aspectj-maven-plugin to version 1.4

          People

          • Assignee:
            Unassigned
            Reporter:
            Maria Jurcovicova
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development