Uploaded image for project: 'Shiro'
  1. Shiro
  2. SHIRO-313

Default SessionManager in web environment for Guice support differs from the otherwise.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.0
    • Component/s: Session Management
    • Labels:
      None

      Description

      Using Ini setup, or simple construction, the default session manager for a web environment uses servlet container sessions. It appears that I overlooked this when adding the Guice integration and made the default for a guice web environment native sessions. Nothing inherently wrong with this other than the glaring inconsistency that I would expect to trip folks up. I am attaching a patch for this to this ticket.

        Activity

        Hide
        lhazlewood Les Hazlewood added a comment -

        Closing with the 1.2.0 release.

        Show
        lhazlewood Les Hazlewood added a comment - Closing with the 1.2.0 release.
        Hide
        deraj123 Jared Bunting added a comment -

        Definitely complete - had been waiting on my access to resolve and then it fell by the wayside once I got that access.

        Show
        deraj123 Jared Bunting added a comment - Definitely complete - had been waiting on my access to resolve and then it fell by the wayside once I got that access.
        Hide
        lhazlewood Les Hazlewood added a comment -

        Jared, is this still outstanding? If so, any way we can resolve it soon? (trying to resolve issues so we can start voting on a 1.2 release)

        Show
        lhazlewood Les Hazlewood added a comment - Jared, is this still outstanding? If so, any way we can resolve it soon? (trying to resolve issues so we can start voting on a 1.2 release)
        Hide
        kaosko Kalle Korhonen added a comment -

        Not at all. Actually first meant to assign to you but then figured I'll just apply it and in the end, just dropped the ball and didn't do either, sorry.

        Show
        kaosko Kalle Korhonen added a comment - Not at all. Actually first meant to assign to you but then figured I'll just apply it and in the end, just dropped the ball and didn't do either, sorry.
        Hide
        deraj123 Jared Bunting added a comment -

        Kalle - any objections to my taking this over and applying the patch?

        Show
        deraj123 Jared Bunting added a comment - Kalle - any objections to my taking this over and applying the patch?

          People

          • Assignee:
            deraj123 Jared Bunting
            Reporter:
            deraj123 Jared Bunting
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development