Shiro
  1. Shiro
  2. SHIRO-313

Default SessionManager in web environment for Guice support differs from the otherwise.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.0
    • Component/s: Session Management
    • Labels:
      None

      Description

      Using Ini setup, or simple construction, the default session manager for a web environment uses servlet container sessions. It appears that I overlooked this when adding the Guice integration and made the default for a guice web environment native sessions. Nothing inherently wrong with this other than the glaring inconsistency that I would expect to trip folks up. I am attaching a patch for this to this ticket.

        Activity

        Jared Bunting created issue -
        Jared Bunting made changes -
        Field Original Value New Value
        Attachment GuiceDefaultSessionManager_SHIRO-313.patch [ 12487103 ]
        Kalle Korhonen made changes -
        Assignee Kalle Korhonen [ kaosko ]
        Hide
        Jared Bunting added a comment -

        Kalle - any objections to my taking this over and applying the patch?

        Show
        Jared Bunting added a comment - Kalle - any objections to my taking this over and applying the patch?
        Hide
        Kalle Korhonen added a comment -

        Not at all. Actually first meant to assign to you but then figured I'll just apply it and in the end, just dropped the ball and didn't do either, sorry.

        Show
        Kalle Korhonen added a comment - Not at all. Actually first meant to assign to you but then figured I'll just apply it and in the end, just dropped the ball and didn't do either, sorry.
        Kalle Korhonen made changes -
        Assignee Kalle Korhonen [ kaosko ]
        Hide
        Les Hazlewood added a comment -

        Jared, is this still outstanding? If so, any way we can resolve it soon? (trying to resolve issues so we can start voting on a 1.2 release)

        Show
        Les Hazlewood added a comment - Jared, is this still outstanding? If so, any way we can resolve it soon? (trying to resolve issues so we can start voting on a 1.2 release)
        Les Hazlewood made changes -
        Assignee Jared Bunting [ deraj123 ]
        Hide
        Jared Bunting added a comment -

        Definitely complete - had been waiting on my access to resolve and then it fell by the wayside once I got that access.

        Show
        Jared Bunting added a comment - Definitely complete - had been waiting on my access to resolve and then it fell by the wayside once I got that access.
        Jared Bunting made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.2.0 [ 12315478 ]
        Resolution Fixed [ 1 ]
        Hide
        Les Hazlewood added a comment -

        Closing with the 1.2.0 release.

        Show
        Les Hazlewood added a comment - Closing with the 1.2.0 release.
        Les Hazlewood made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        167d 23h 46m 1 Jared Bunting 04/Jan/12 03:36
        Resolved Resolved Closed Closed
        19d 21h 35m 1 Les Hazlewood 24/Jan/12 01:11

          People

          • Assignee:
            Jared Bunting
            Reporter:
            Jared Bunting
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development