Shiro
  1. Shiro
  2. SHIRO-277

JdbcRealm needs to be refactored

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.3.0
    • Component/s: Realms
    • Labels:
      None

      Description

      There are at least 2 obvious problems:
      1) the javadoc for JdbcRealm.setPermissionsQuery suggests that the query is expected to have 3 columns ("containing the fully qualified name of the permission class, the permission name, and the permission actions (in that order)"), but the code actually looks only for 1 - permission actions on index 0
      2) it doesn't support salt - checks only for password matching

      1. jdbcRealm.patch
        24 kB
        Phil Steitz

        Activity

        Ilya Pyatigorskiy created issue -
        Les Hazlewood made changes -
        Field Original Value New Value
        Fix Version/s 1.2.0 [ 12315478 ]
        Priority Minor [ 4 ] Major [ 3 ]
        Phil Steitz made changes -
        Attachment jdbcRealm.patch [ 12486787 ]
        Phil Steitz made changes -
        Attachment jdbcRealm.patch [ 12486787 ]
        Phil Steitz made changes -
        Attachment jdbcRealm.patch [ 12486788 ]
        Les Hazlewood made changes -
        Fix Version/s 1.3.0 [ 12317961 ]
        Fix Version/s 1.2.0 [ 12315478 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Ilya Pyatigorskiy
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development