Shiro
  1. Shiro
  2. SHIRO-275

JdbcRealm.doGetAuthenticationInfo doesn't follow javadoc

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.1.0
    • Fix Version/s: None
    • Component/s: Realms
    • Labels:
      None

      Description

      This was discussed on the mailing list and my point is:

      The javadoc says "A null return value means that no account could be associated with the specified token." and "@throws org.apache.shiro.authc.AuthenticationException if there is an error acquiring data or performing realm-specific authentication logic for the specified <tt>token</tt>". The only way that would be acceptable is if we say that no user in the database is "an error acquiring data" which seems a bit stretched.

      This causes confusion and may result in errors for someone implementing a Strategy or Authenticator who would not expect such behaviour.

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            Unassigned
            Reporter:
            Ilya Pyatigorskiy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development