Shiro
  1. Shiro
  2. SHIRO-244

Typo in IniSecurityManagerFactory causes a requirement for a dummy Realm in addition to a RealmFactory

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Duplicate
    • Affects Version/s: 1.1.0
    • Fix Version/s: None
    • Component/s: Realms
    • Labels:
      None

      Description

      In the private addToRealms-method of IniSecurityManagerFactory, there is a check:

      Collection<Realm> factoryRealms = factory.getRealms();
      if (!CollectionUtils.isEmpty(realms))

      { realms.addAll(factoryRealms); }

      The if-clause should be against the factoryRealms variable, as this check forces one to create a dummy Realm in the configuration file in order for the factory created Realms to be added as well.

        Activity

        Hide
        Esa Loukkola added a comment -

        Duplicate of SHIRO-238

        Show
        Esa Loukkola added a comment - Duplicate of SHIRO-238
        Hide
        Esa Loukkola added a comment -

        Fix commited w/ SHIRO-238

        Show
        Esa Loukkola added a comment - Fix commited w/ SHIRO-238

          People

          • Assignee:
            Unassigned
            Reporter:
            Esa Loukkola
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.25h
              0.25h
              Remaining:
              Remaining Estimate - 0.25h
              0.25h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development