Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0, 1.2.0
    • Fix Version/s: 1.3.0
    • Component/s: Web
    • Labels:
      None
    • Environment:
      JSF 1.2 / Facelets 1.1.14

      Description

      The attached patch implements a new support module 'shiro-faces' that implements a tag library compatible with Facelets, that can be used in JSF 1.2 projects. The tags are based on the original JSP tags, available in the web module.

      1. shiro-faces-jsf2.zip
        23 kB
        Deluan Quintao
      2. shiro-faces-support.patch
        41 kB
        Deluan Quintao

        Issue Links

          Activity

          Hide
          Yannick Britis added a comment -

          Ok it's working. I just changed the namespace used to http://shiro.apache.org/tags/facelets instead of http://shiro.apache.org/tags.

          Show
          Yannick Britis added a comment - Ok it's working. I just changed the namespace used to http://shiro.apache.org/tags/facelets instead of http://shiro.apache.org/tags .
          Hide
          Yannick Britis added a comment -

          I found the jar here : http://deluan.googlecode.com/svn/snapshots/org/apache/shiro/shiro-faces/1.0-SNAPSHOT/

          After adding the jar into my project, Tomcat is telling me that the shiro-facelets.taglib.xml is correctly read, but the tags are still not interpreted. Any ideas? Maybe a conflict between the namespaces?

          Show
          Yannick Britis added a comment - I found the jar here : http://deluan.googlecode.com/svn/snapshots/org/apache/shiro/shiro-faces/1.0-SNAPSHOT/ After adding the jar into my project, Tomcat is telling me that the shiro-facelets.taglib.xml is correctly read, but the tags are still not interpreted. Any ideas? Maybe a conflict between the namespaces?
          Hide
          Yannick Britis added a comment -

          Thank you for answering me so quickly .
          Does this version works with JSF 1.2? Because when I looked at the pom I noticed dependencies for JSF 2, not 1.2.

          Show
          Yannick Britis added a comment - Thank you for answering me so quickly . Does this version works with JSF 1.2? Because when I looked at the pom I noticed dependencies for JSF 2, not 1.2.
          Hide
          Deluan Quintao added a comment -

          Hi Yannick, the last version I built can be found here: http://deluan.googlecode.com/svn/snapshots/org/apache/shiro/shiro-faces/2.0-SNAPSHOT

          -Deluan

          Show
          Deluan Quintao added a comment - Hi Yannick, the last version I built can be found here: http://deluan.googlecode.com/svn/snapshots/org/apache/shiro/shiro-faces/2.0-SNAPSHOT -Deluan
          Hide
          Yannick Britis added a comment -

          Thanks to Deluan Quintao for this patch! But I'm having troubles with it.
          I'm using JSF 1.2 and Shiro 1.2.2 (and NOT using Maven). In order to get those tags I downloaded the jar of shiro-faces 1.0 but it is corrupted.
          How can I get a correct version of this jar?

          Thanks in advance for helping me

          Show
          Yannick Britis added a comment - Thanks to Deluan Quintao for this patch! But I'm having troubles with it. I'm using JSF 1.2 and Shiro 1.2.2 (and NOT using Maven). In order to get those tags I downloaded the jar of shiro-faces 1.0 but it is corrupted. How can I get a correct version of this jar? Thanks in advance for helping me
          Hide
          Les Hazlewood added a comment -

          I am unaware why you posted to this thread. This issue has been closed - the JSF support you ask of has already been included in the trunk and will be in Shiro 1.3.0 (read the comment immediately above yours).

          Show
          Les Hazlewood added a comment - I am unaware why you posted to this thread. This issue has been closed - the JSF support you ask of has already been included in the trunk and will be in Shiro 1.3.0 (read the comment immediately above yours).
          Hide
          shiro added a comment -

          I would love to see the JSF tag lib included : http://techbeats.deluan.com/apache-shiro-tags-for-jsffacelets

          Is there a shiro road map sowewhere?

          We cant wait to see Shiro with full JSF 2 support!

          Show
          shiro added a comment - I would love to see the JSF tag lib included : http://techbeats.deluan.com/apache-shiro-tags-for-jsffacelets Is there a shiro road map sowewhere? We cant wait to see Shiro with full JSF 2 support!
          Hide
          Les Hazlewood added a comment -

          Correction, this was not released in 1.2.0 - this was added in trunk and will be released in 1.3.0

          Show
          Les Hazlewood added a comment - Correction, this was not released in 1.2.0 - this was added in trunk and will be released in 1.3.0
          Hide
          Les Hazlewood added a comment -

          This was released in 1.2.0 as a new 'faces' support module.

          Show
          Les Hazlewood added a comment - This was released in 1.2.0 as a new 'faces' support module.
          Hide
          Les Hazlewood added a comment -

          Thanks so much!

          Show
          Les Hazlewood added a comment - Thanks so much!
          Hide
          Deluan Quintao added a comment - - edited

          Hi Lez, here is the latest version of Shiro Faces, compatible with JSF 2, as a zip file. Thanks!

          Show
          Deluan Quintao added a comment - - edited Hi Lez, here is the latest version of Shiro Faces, compatible with JSF 2, as a zip file. Thanks!
          Hide
          Les Hazlewood added a comment -

          P.S. if a .zip attachment is easiest for you Deluan, that's fine - I can structure the code in a support module as necessary.

          Show
          Les Hazlewood added a comment - P.S. if a .zip attachment is easiest for you Deluan, that's fine - I can structure the code in a support module as necessary.
          Hide
          Les Hazlewood added a comment -

          Thanks Deluan,

          Can you please provide the entire project source code as a patch or .zip attachment to this issue? That signifies it formally as a 'contribution to the ASF'. While we can use Apache 2 Licensed code ourselves, it would leave no room for interpretation if you (the original author) submitted it to us directly. That would help greatly!

          Show
          Les Hazlewood added a comment - Thanks Deluan, Can you please provide the entire project source code as a patch or .zip attachment to this issue? That signifies it formally as a 'contribution to the ASF'. While we can use Apache 2 Licensed code ourselves, it would leave no room for interpretation if you (the original author) submitted it to us directly. That would help greatly!
          Hide
          Deluan Quintao added a comment -

          Hi Lez, I added an Apache license file to my code at GitHub. Let me know if there's any more action I should take.

          Thanks,
          Deluan

          Show
          Deluan Quintao added a comment - Hi Lez, I added an Apache license file to my code at GitHub. Let me know if there's any more action I should take. Thanks, Deluan
          Hide
          Les Hazlewood added a comment - - edited

          Due to compatibility issues, we can't backport new features into older releases. We adhere to the APR versioning guidelines: http://apr.apache.org/versioning.html. This is done for very good reason - Shiro's perceived stability is critical for companies that use it. If we deviated from these guidelines, we risk incompatibility issues that could significantly hurt the image of the project.

          For example, if we added it to a 1.1.1 release, and you upgraded to Shiro 1.2.0, your upgrade would fail (because this code was not present in the 1.2.0 release). This scenario breaks APR versioning upgrade semantics, which is why it would have to be added to 1.3.

          Similarly, we can't add this to 1.2.1 because point versions (i.e. Major.Minor.Point) are expected to be both forwards and backwards compatible. That is, I must be able to use 1.2.8 and downgrade to 1.2.0 without compile-time repercussions. If a new major feature like this was in 1.2.1 and not 1.2.0 the downgrade would fail.

          For these reasons, until 1.3 comes out, this module must be released independently of Shiro's release. But if we can get it in to 1.3.0-SNAPSHOT versions right now, that'd be great - I'm just looking for a more modern 'cut' of Deluan's code, presented by Deluan himself.

          The reason this must occur is that Deluan does not currently have licensing information in his code in GitHub. As an Apache-managed project, we cannot copy code that isn't already associated with an Apache compatible license. Until Deluan licenses his GitHub project entirely as Apache 2 licensed, or he submits a patch to our Jira (which constitutes a valid ASF contribution), I can't copy it.

          Deluan if you could give us an updated patch, I'd appreciate it!

          Show
          Les Hazlewood added a comment - - edited Due to compatibility issues, we can't backport new features into older releases. We adhere to the APR versioning guidelines: http://apr.apache.org/versioning.html . This is done for very good reason - Shiro's perceived stability is critical for companies that use it. If we deviated from these guidelines, we risk incompatibility issues that could significantly hurt the image of the project. For example, if we added it to a 1.1.1 release, and you upgraded to Shiro 1.2.0, your upgrade would fail (because this code was not present in the 1.2.0 release). This scenario breaks APR versioning upgrade semantics, which is why it would have to be added to 1.3. Similarly, we can't add this to 1.2.1 because point versions (i.e. Major.Minor.Point) are expected to be both forwards and backwards compatible. That is, I must be able to use 1.2.8 and downgrade to 1.2.0 without compile-time repercussions. If a new major feature like this was in 1.2.1 and not 1.2.0 the downgrade would fail. For these reasons, until 1.3 comes out, this module must be released independently of Shiro's release. But if we can get it in to 1.3.0-SNAPSHOT versions right now, that'd be great - I'm just looking for a more modern 'cut' of Deluan's code, presented by Deluan himself. The reason this must occur is that Deluan does not currently have licensing information in his code in GitHub. As an Apache-managed project, we cannot copy code that isn't already associated with an Apache compatible license. Until Deluan licenses his GitHub project entirely as Apache 2 licensed, or he submits a patch to our Jira (which constitutes a valid ASF contribution), I can't copy it. Deluan if you could give us an updated patch, I'd appreciate it!
          Hide
          Dan Tran added a comment -

          Les, I think you can just pull in from git hub and release shiro-faces for 1.1 first. I do believe there are lots of shiro 1.1 that need this package. My production build has been using Deluan's shiro faces for quite some time.

          Show
          Dan Tran added a comment - Les, I think you can just pull in from git hub and release shiro-faces for 1.1 first. I do believe there are lots of shiro 1.1 that need this package. My production build has been using Deluan's shiro faces for quite some time.
          Hide
          Les Hazlewood added a comment -

          Deluan, can you please provide an up-to-date/recent patch for this? If the rest of the dev team doesn't have any issues with it, I'd be happy to make this part of Shiro's support modules (likely in the 1.3 release).

          Show
          Les Hazlewood added a comment - Deluan, can you please provide an up-to-date/recent patch for this? If the rest of the dev team doesn't have any issues with it, I'd be happy to make this part of Shiro's support modules (likely in the 1.3 release).
          Hide
          Dan Tran added a comment -

          can we have proper release for this ( ie push it up to Maven central? )

          Show
          Dan Tran added a comment - can we have proper release for this ( ie push it up to Maven central? )
          Hide
          Marcus Riemer added a comment -

          Thanks alot for your great work Deluan. Seems to work just fine with Faces 2.0 and Shiro 1.2.0.

          Show
          Marcus Riemer added a comment - Thanks alot for your great work Deluan. Seems to work just fine with Faces 2.0 and Shiro 1.2.0.
          Hide
          Dan Tran added a comment -

          Yes, you new shiro-faces 2.0-SNAPSHOT works great. Do you maintain independently? if so could you make sure it is pushed to maven central at release time and you will need to change the groupId

          Show
          Dan Tran added a comment - Yes, you new shiro-faces 2.0-SNAPSHOT works great. Do you maintain independently? if so could you make sure it is pushed to maven central at release time and you will need to change the groupId
          Hide
          Deluan Quintao added a comment -

          Hi Dan, while this patch isn't incorporated, I'm maintaining it as an independent project at https://github.com/deluan/shiro-faces.

          Show
          Deluan Quintao added a comment - Hi Dan, while this patch isn't incorporated, I'm maintaining it as an independent project at https://github.com/deluan/shiro-faces .
          Hide
          Dan Tran added a comment -

          any chance this patch will become a shiro sub project .. so that it get proper release?

          Show
          Dan Tran added a comment - any chance this patch will become a shiro sub project .. so that it get proper release?

            People

            • Assignee:
              Les Hazlewood
              Reporter:
              Deluan Quintao
            • Votes:
              13 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development