Shiro
  1. Shiro
  2. SHIRO-198

HostAuthenticationToken does not extend AuthenticationToken

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.2.0
    • Labels:
      None

      Description

      The HostAuthenticationToken interface by name has a strong relationship with AuthenticationToken. However, it does not extend that interface. By contrast, RememberMeAuthenticationToken does extend AuthenticationToken. This seems like an oversight in this interface's definition.

      Note: I realize this is very trivial; I'm just opening this issue to track that this may need to be changed.

        Activity

        Hide
        Les Hazlewood added a comment -

        Patch applied. Thanks!

        Show
        Les Hazlewood added a comment - Patch applied. Thanks!
        Hide
        Bryan Turner added a comment -

        Attaching a patch, in case it will be helpful.

        Show
        Bryan Turner added a comment - Attaching a patch, in case it will be helpful.

          People

          • Assignee:
            Les Hazlewood
            Reporter:
            Bryan Turner
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development