Details

    • Type: Sub-task Sub-task
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.0
    • Fix Version/s: None
    • Component/s: Javascript
    • Labels:
      None

      Activity

      Hide
      Kevin Brown added a comment -

      almost forgot –

      this also requires that RPC become core

      Show
      Kevin Brown added a comment - almost forgot – this also requires that RPC become core
      Hide
      Kevin Brown added a comment -

      You don't need an explicit dependency on core.

      Show
      Kevin Brown added a comment - You don't need an explicit dependency on core.
      Hide
      Paul Lindner added a comment -

      how about just moving views/views.js and the rpc dependency to core and then make views depend on core?

      Show
      Paul Lindner added a comment - how about just moving views/views.js and the rpc dependency to core and then make views depend on core?
      Hide
      Kevin Brown added a comment -

      the feature loader doesn't deal with cyclical dependencies.
      renaming "views" to "core.views" and then adding a place holder so that existing gadgets that require "views" don't blow up should work.

      Show
      Kevin Brown added a comment - the feature loader doesn't deal with cyclical dependencies. renaming "views" to "core.views" and then adding a place holder so that existing gadgets that require "views" don't blow up should work.
      Hide
      Paul Lindner added a comment -

      naive patch?

      diff --git a/features/src/main/javascript/features/core/feature.xml b/features/src/main/javascript/features/core/feature.xml
      index b1d4b14..eed95d8 100644
      — a/features/src/main/javascript/features/core/feature.xml
      +++ b/features/src/main/javascript/features/core/feature.xml
      @@ -18,6 +18,7 @@
      -->
      <feature>
      <name>core</name>
      + <dependency>views</dependency>
      <gadget>
      <script src="core.js"/>
      <script src="config.js"/>

      Show
      Paul Lindner added a comment - naive patch? diff --git a/features/src/main/javascript/features/core/feature.xml b/features/src/main/javascript/features/core/feature.xml index b1d4b14..eed95d8 100644 — a/features/src/main/javascript/features/core/feature.xml +++ b/features/src/main/javascript/features/core/feature.xml @@ -18,6 +18,7 @@ --> <feature> <name>core</name> + <dependency>views</dependency> <gadget> <script src="core.js"/> <script src="config.js"/>
      Hide
      Adam Winer added a comment -

      Per http://opensocial-resources.googlecode.com/svn/spec/draft/Gadgets-API-Specification.xml, the "views" feature is now part of the core gadgets JS, and should not need to be explicitly loaded.

      Show
      Adam Winer added a comment - Per http://opensocial-resources.googlecode.com/svn/spec/draft/Gadgets-API-Specification.xml , the "views" feature is now part of the core gadgets JS, and should not need to be explicitly loaded.

        People

        • Assignee:
          Unassigned
          Reporter:
          Adam Winer
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:

            Development