Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-951

setFieldImpl does not handle boolean false values

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.1-BETA1
    • 1.0, 1.1-BETA1
    • PHP
    • None

    Description

      In php/src/social/model/Person.php the setFieldImpl method checks that the new value is not empty. Hoewer this is done with the operator ==, and this results in false values being replaced by null, so not sent at all.

      This breaks the setIsOwner() and setIsViewer() methods, and caused me fail multiple tests in the compliance test.

      I hope this change does not break anything else.

      Patch following...

      Attachments

        1. shindig_person_field_impl.patch
          0.5 kB
          Nagy Attila

        Activity

          People

            Unassigned Unassigned
            mrbig Nagy Attila
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: