Shindig
  1. Shindig
  2. SHINDIG-921

CacheMemcache replace dynamic connection with static?

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: 1.0, 1.1-BETA1
    • Component/s: PHP
    • Labels:
      None

      Description

      Class CacheMemcache stores the open memcache connection in the internal $connection variable.

      I propose this should be replaced with a class static variable, thus elliminating multiple calls to memcache_pconnect() during one run. This could be very usefull also if one wants to replace pconnect with standard connect.

        Activity

        Hide
        Chris Chabot added a comment -

        Ah nice catch! Indeed that does make a lot more sense.

        I'll do the actual committing of the patch once apache's svn server's maintenance is done (it's in read only mode at the moment).

        Show
        Chris Chabot added a comment - Ah nice catch! Indeed that does make a lot more sense. I'll do the actual committing of the patch once apache's svn server's maintenance is done (it's in read only mode at the moment).
        Hide
        Nagy Attila added a comment -

        Patch against branch 1.0.x-incubating attached

        Show
        Nagy Attila added a comment - Patch against branch 1.0.x-incubating attached

          People

          • Assignee:
            Chris Chabot
            Reporter:
            Nagy Attila
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development