Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-89

Prefs / view parameter escaping

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • None
    • Javascript
    • None

    Description

      Currently, we do not escape gadgets.Prefs or gadgets.views parameters.

      This could potentially result in exploits of data by malicious outside sites.

      To remedy this, I propose the attached patch.

      As it stands, the spec is silent on the escaping issue, but in practice gmodules.com already does this escaping for user prefs and I suspect that other container sites do as well.

      I've also included an unescaping mechanism that I think should ultimately be proposed to the spec discussion group, but that's a later issue.

      Feedback is much appreciated. If no one objects, I'll commit this change tomorrow morning.

      Attachments

        1. escaping-patch.patch
          5 kB
          Kevin Brown

        Activity

          People

            etnu Kevin Brown
            etnu Kevin Brown
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: