Shindig
  1. Shindig
  2. SHINDIG-869

Ignore SVN files in shindig-features-XXX.jar

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0, 1.1-BETA1
    • Fix Version/s: 1.0, 1.1-BETA1
    • Component/s: Javascript
    • Labels:
      None

      Description

      Actually, the shindig-features-XXX.jar contains IDE files, for instance .classpath. We should remove them.

      1. SHINDIG-869.patch
        5 kB
        Vincent Siveton

        Activity

        Vincent Siveton created issue -
        Hide
        Vincent Siveton added a comment -

        This patch contains:

        • ordered Maven plugins
        • ignored files like define in the etc/svn-ignores

        Since I am there, I also configured yuicompressor-maven-plugin to not pollute the build with warn/info logs, ie

        • jswarn=false
        • statistics=false
        Show
        Vincent Siveton added a comment - This patch contains: ordered Maven plugins ignored files like define in the etc/svn-ignores Since I am there, I also configured yuicompressor-maven-plugin to not pollute the build with warn/info logs, ie jswarn=false statistics=false
        Vincent Siveton made changes -
        Field Original Value New Value
        Attachment SHINDIG-869.patch [ 12398021 ]
        Hide
        Paul Lindner added a comment -

        looks good reduced features jar by a few kilobytes.

        Show
        Paul Lindner added a comment - looks good reduced features jar by a few kilobytes.
        Paul Lindner made changes -
        Fix Version/s trunk [ 12313552 ]
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Hide
        Vincent Siveton added a comment -

        Paul, could you merge this patch to the branch?

        Show
        Vincent Siveton added a comment - Paul, could you merge this patch to the branch?
        Hide
        Paul Lindner added a comment -

        This patch depends on SHINDIG-820, SHINDIG-821

        Should those get merged too?

        Show
        Paul Lindner added a comment - This patch depends on SHINDIG-820 , SHINDIG-821 Should those get merged too?
        Paul Lindner made changes -
        Fix Version/s 1.0.x-incubating [ 12313553 ]
        Hide
        Vincent Siveton added a comment -

        fixed in r735073 and r750907

        Show
        Vincent Siveton added a comment - fixed in r735073 and r750907
        Ian Boston made changes -
        Affects Version/s 1.0.x-incubating [ 12313553 ]
        Affects Version/s 1.0.0-rc1 [ 12313551 ]
        Gavin made changes -
        Workflow jira [ 12450358 ] patch-available, re-open possible [ 12628645 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Vincent Siveton
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development