Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-806

Move Javascript in the features directory in a better location

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: 1.0, 1.1-BETA1
    • Component/s: Javascript
    • Labels:
      None

      Description

      Having the feature subdirectories right under the features folder is actually some kind of PITA whenever you want to turn this into an IDE project (e.g. eclipse). I'd like to move the javascript into src/main/javascript and the tests into src/test/javascript. This also would allow to package up the code without the tests.

      However, this is either one really, really big patch or small one with a number of additional file moves:

      the following files go into src/test/javascript/<subdirectory>

      ./core/authtest.js
      ./core.io/iotest.js
      ./core/prefstest.js
      ./core/utiltest.js
      ./mocks/env.js
      ./mocks/xhr.js
      ./opensocial-base/jsonactivitytest.js
      ./opensocial-reference/activitytest.js
      ./opensocial-templates/compiler_test.js
      ./opensocial-templates/container_test.js
      ./opensocial-templates/data_test.js
      ./opensocial-templates/domutil.js
      ./opensocial-templates/loader_test.js
      ./opensocial-templates/os_test.js
      ./opensocial-templates/ost_test.html
      ./opensocial-templates/README
      ./opensocial-templates/template_test.js
      ./opensocial-templates/util_test.js
      ./views/urltemplatetest.js

      Then move the following directories:

      analytics auth-refresh caja core core.io dynamic-height flash locked-domain opensocial-* pubsub rpc setprefs settitle skins tabs views and feature.txt to src/main/javascript
      mocks to src/test/javascript

      And apply the attached patch. Then the features directory builds as a "real" maven project; also the produced jar no longer contains the test javascript.

        Attachments

        1. SHINDIG-806.patch
          3 kB
          Henning Schmiedehausen

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              henning Henning Schmiedehausen
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: