[SHINDIG-803] hasFeature does not work

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0
• Fix Version/s: 2.0.0-RC2
• Component/s: Java, Javascript
• Assignee: Unassigned
• Reporter: Henning Schmiedehausen
• Created: 19/Dec/08 03:28
• Updated: 14/Jun/10 20:49
• Resolved: 14/Jun/10 20:49

Description

Digging through the code; I have a test gadget that displays the compliance level of a javascript container. It is available at http://henning.schmiedehausen.org/gadgets/check.xml. This loads all opensocial features as optional and then displays the results of hasFeature(), which should only be true if a feature actually exists.

Consider me surprised, when this gadget found out that most popular containers already support opensocial-1.0.

The current shindig code builds an array of features from the gadget in RenderingContentRewriter.java:354. For all features referenced by the gadget, this will contain an entry with the configuration. Even for the ones that are optional.

in core.io/utils.js, the hasFeature() method only tests the presence of a key in this array. Which is always present if a feature is referenced by the gadget spec. No matter whether it exists or not. It will always report the feature existing. As the Optional/hasFeature combo is the only way to find out whether a given feature requested by a gadget is actually present, I consider this a bug.

Issue Links

• is part of: SHINDIG-805 Modularize contributors to gadgets.config.init and make them injectable