Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1-BETA1
    • Component/s: None
    • Labels:
      None

      Activity

      Gavin made changes -
      Workflow jira [ 12447611 ] patch-available, re-open possible [ 12629058 ]
      Adam Winer made changes -
      Status Open [ 1 ] Resolved [ 5 ]
      Fix Version/s 1.1-M1 [ 12313552 ]
      Resolution Fixed [ 1 ]
      Hide
      Adam Winer added a comment -

      Implemented in Java as well.

      Show
      Adam Winer added a comment - Implemented in Java as well.
      Hide
      Chris Chabot added a comment -

      This issue has been fixed in the PHP implementation, feel free to close the issue if/once it's done in the Java implementation

      Show
      Chris Chabot added a comment - This issue has been fixed in the PHP implementation, feel free to close the issue if/once it's done in the Java implementation
      awiner committed 761018 (4 files)
      Reviews: none

      SHINDIG-1002: HttpRequest format="text" does not function
      and
      SHINDIG-739: Data Pipelining (in part)

      Follow revised spec of os:HttpRequest output format, specifically:
         - Move content into a "content" property
         - Include headers (a limited set) and http status code
         - Support JSON arrays in addition to text
         - Support HTTP errors - report them in an "error" block
         - If JSON parsing fails, treat as a 406 error
      The above makes resolving SHINDIG-1002 tractable, and:

            <script xmlns:os="http://ns.opensocial.org/2008/markup" type="text/os-data">
              <os:HttpRequest key="google" href="http://www.google.com" format="text"/>
            </script>

            <script type="text/os-template" xmlns:os="http://ns.opensocial.org/2008/markup">
              <os:Html code="${google.content}"/>
           </script>

      ... now sorta works (except that there isn't any content fixup for relative URLs).

      Write lots of tests for the HTTP pipeline format, both unit and end-to-end.

      awiner committed 747227 (16 files)
      Reviews: none

      SHINDIG-739: Data pipelining (in part)
      - Extract DataContext api into an opensocial-data-context feature, depended on by opensocial-data
      - If server-side data pipelining succeeds completely, remove the opensocial-data feature and add the opensocial-data-context feature instead
      - Rewrite DataContext to hide implementation better, and write test
      - Add support for registerListener('*', ...) per spec
      - Tweak other opensocial-related tests to work in JSUnit (not relying on 'window' variable)
      - Fix name of os:MakeRequest element (now os:HttpRequest per spec)

      awiner committed 745175 (2 files)
      Reviews: none

      SHINDIG-739: Data Pipelining (in part)
      Implement @params on os:HttpRequest. Implementation does not yet properly escape
      EL evaluation per the current spec.

      Adam Winer made changes -
      Field Original Value New Value
      Assignee Adam Winer [ adamwiner ]
      Hide
      Kevin Brown added a comment -

      Pipelining has been committed to the Java code base as of r727123. This implementation works well, but isn't as efficient as it could be.

      Show
      Kevin Brown added a comment - Pipelining has been committed to the Java code base as of r727123. This implementation works well, but isn't as efficient as it could be.
      Kevin Brown created issue -

        People

        • Assignee:
          Adam Winer
          Reporter:
          Kevin Brown
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development