Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-693

Shindig's content rewriting changes @type attribute of <script> tag

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0, 1.1-BETA1
    • Component/s: Java
    • Labels:
      None

      Description

      When the gadget XML is rendered with content rewriting enabled, all <script type="text/os-template"> are turned into <script type="text/javascript">. In fact, any script tag's @type attribute will be changed to "text/javascript" (this is added if no @type exists in the original XML).

      This is problematic. The Opensocial Template spec (http://wiki.opensocial-templates.org/index.php?title=OpenSocial_Templating#Template_Format) calls for the wrapping of templates in <script type="text/os-template"> .. </script> tags. Currently, the only way to get this to work in shindig is to disable content rewriting entirely, which is obviously problematic.

      It seems like the correct behavior would be for the content rewriter to leave the @type attribute as is, only setting it to "text/javascript" if it's missing.

        Attachments

          Activity

            People

            • Assignee:
              lryan Louis Ryan
              Reporter:
              levik Lev Epshteyn
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: