Shindig
  1. Shindig
  2. SHINDIG-643

Create a single location for root paths.

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Java, Javascript , PHP
    • Labels:
      None

      Description

      Currently there are at least 12 places where you can potentially have to configure urls for running Shindig. We need to standardize how these are going to be handled.

      1. SHINDIG-643.patch
        30 kB
        jeremi Joslin

        Issue Links

          Activity

          Hide
          Chris Chabot added a comment -

          on the php side of things, there are 2 places for this (which imo is 1 to many):
          shindig/config/container.js and
          shindig/php/config/container.php

          i'd be more then happy to base the path construction of the one on the other (doesn't matter so much to me which is the master in this regard, having it in the php config would be easier for the end users, but if that would affect consistency between the 2 versions, imo that's not a sacrifice worth making)

          Show
          Chris Chabot added a comment - on the php side of things, there are 2 places for this (which imo is 1 to many): shindig/config/container.js and shindig/php/config/container.php i'd be more then happy to base the path construction of the one on the other (doesn't matter so much to me which is the master in this regard, having it in the php config would be easier for the end users, but if that would affect consistency between the 2 versions, imo that's not a sacrifice worth making)
          Hide
          Kevin Brown added a comment -

          My vote is for putting into container config, for 4 reasons:

          1. Consistency between client and server configuration
          2. Consistency between Java & PHP implementations
          3. Consistency in our support for deployments that need to support multiple containers.
          4. Consistency in locating configuration options.

          Ideally, I'd like the only PHP or java-specific configuration to be pointers to the locations of the features.xml & container configuration files, and details that are actually language specific and simply don't exist in other implementations. Anytime where we have to document two different ways to configure the same thing, it hurts our users.

          Show
          Kevin Brown added a comment - My vote is for putting into container config, for 4 reasons: 1. Consistency between client and server configuration 2. Consistency between Java & PHP implementations 3. Consistency in our support for deployments that need to support multiple containers. 4. Consistency in locating configuration options. Ideally, I'd like the only PHP or java-specific configuration to be pointers to the locations of the features.xml & container configuration files, and details that are actually language specific and simply don't exist in other implementations. Anytime where we have to document two different ways to configure the same thing, it hurts our users.
          Hide
          jeremi Joslin added a comment -

          This patch move the configuration of the content-rewrite from the shindig.properties to the container.js in shindig java.
          It also enable to have different rewriting for each container.

          Can anyone review it?

          Show
          jeremi Joslin added a comment - This patch move the configuration of the content-rewrite from the shindig.properties to the container.js in shindig java. It also enable to have different rewriting for each container. Can anyone review it?
          Hide
          Kevin Brown added a comment -

          I have a family emergency and will not be available regularly this week.

          Contacts:

          Production release issues: opensocial-sre, lryan
          Sandbox issues: opensocial-eng, awiner

          Show
          Kevin Brown added a comment - I have a family emergency and will not be available regularly this week. Contacts: Production release issues: opensocial-sre, lryan Sandbox issues: opensocial-eng, awiner
          Hide
          Karl Matthias added a comment -

          The PHP Readme is also out of date on this issue. If I hadn't found this bug with the correct information I could not have set up the server in a path other than webroot.

          Show
          Karl Matthias added a comment - The PHP Readme is also out of date on this issue. If I hadn't found this bug with the correct information I could not have set up the server in a path other than webroot.
          Hide
          Vincent Siveton added a comment -

          Jeremi: could you update your patch under the current trunk?

          Show
          Vincent Siveton added a comment - Jeremi: could you update your patch under the current trunk?

            People

            • Assignee:
              Unassigned
              Reporter:
              Kevin Brown
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Development