[SHINDIG-1923] ClassCastException: org.apache.shindig.common.uri.Uri cannot be cast to java.lang.String

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.0-beta6
• Fix Version/s: 2.5.1, 2.5.0-update1
• Assignee: Ryan Baxter
• Reporter: Gary Brown
• Created: 01/Aug/13 13:52
• Updated: 19/Aug/13 23:52
• Resolved: 19/Aug/13 23:52

Description

I recently upgraded from 3.0.0-beta4 to 2.5.0-beta6, and found that the MetadataResponse had changed from getIframeUrl to getIframeUrls (Map<String,String>). However when I try accessing the value in this map I am getting a ClassCastException.

When looking in the code I noticed,

https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java

the MetadataResponse inner class has a method getIframeUrls() with return type Map<String,String>.

However in:

https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java

the method getMetadata() shows the urls are defined as type Map<String,Uri>.

As the MetadataResponse API has been changed anyway, could it not just be changed to Map<String,Uri>? Or alternatively transform the map inside the GadgetsHandlerService?