[SHINDIG-1922] Pubsub gadgets fail to render in commoncontainer

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.0, 2.5.0-beta6
• Fix Version/s: 2.5.0
• Assignee: Ryan Baxter
• Reporter: Ryan Baxter
• Created: 22/Jul/13 01:13
• Updated: 26/Jul/13 00:28
• Resolved: 26/Jul/13 00:28

Description

In webkit browsers the onload handler gets called twice, which ends up
removing the iframe from the DOM. After looking at there appears to
be a few problems with the pubsub code and the onload handlers added
to the iframe. We add it in the iframe attributes and then add it to
the iframe again later on, which seems unneccessary. I think the root
cause of the onload listener being called twice has to do with onload
listener being added in the innerHTML string [1]. I will try to get
the change fix checked in over the next few days.

[1] http://stackoverflow.com/questions/10781880/why-iframe-that-dynamic-created-trigger-onload-event-twice

Issue Links

• links to: Code Review