[SHINDIG-1920] Don't force cache time-to-lives on responses with an error status

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.0-beta6
• Fix Version/s: 2.5.0
• Component/s: Java
• Assignee: Stanton Sievers
• Reporter: Stanton Sievers
• Created: 02/Jun/13 13:35
• Updated: 06/Jun/13 13:29
• Resolved: 06/Jun/13 13:29

Description

org.apache.shindig.gadgets.DefaultGadgetSpecFactory and org.apache.shindig.gadgets.DefaultMessageBundleFactory utilize a property in shindig.properties (shindig.cache.xml.refreshInterval) to force the RequestPipeline/Fetcher layer to cache specs and message bundles for a set amount of time, regardless of the cache headers on the response. This also forces the cache ttl in the case that the response is an error instead of using the "shindig.cache.http.negativeCacheTtl" value in shindig.properties, which defaults to one minute.

I'd rather we always use the negativeCacheTtl in this case and ignore the forced cache ttl