Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.0-beta1, 2.5.0
    • Fix Version/s: 2.5.0-beta2
    • Component/s: Java
    • Labels:
      None

      Description

      Currently makeRequest does not forward the User-Agent header from the browser. This makes it impossible for intermediate processing or backend processing to customize responses for different browsers.

      1. 1781_20120518.patch
        0.7 kB
        Adam Clarke
      2. 1781_20120521.patch
        2 kB
        Adam Clarke

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5162/
        -----------------------------------------------------------

        Review request for shindig.

        Summary
        -------

        Passes the User-Agent header so intermediate (or even backend processing) can make browser-specific customizations.

        This addresses bug SHINDIG-1781.
        https://issues.apache.org/jira/browse/SHINDIG-1781

        Diffs


        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1340074

        Diff: https://reviews.apache.org/r/5162/diff

        Testing
        -------

        All tests pass.

        Thanks,

        Adam

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5162/ ----------------------------------------------------------- Review request for shindig. Summary ------- Passes the User-Agent header so intermediate (or even backend processing) can make browser-specific customizations. This addresses bug SHINDIG-1781 . https://issues.apache.org/jira/browse/SHINDIG-1781 Diffs http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1340074 Diff: https://reviews.apache.org/r/5162/diff Testing ------- All tests pass. Thanks, Adam
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5162/#review7972
        -----------------------------------------------------------

        Ship it!

        LGTM. Having an additional MakeRequestHandlerTest that verifies that the user-agent is ferried along would be a welcome addition to the patch.

        • Stanton

        On 2012-05-18 16:21:01, Adam Clarke wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5162/

        -----------------------------------------------------------

        (Updated 2012-05-18 16:21:01)

        Review request for shindig.

        Summary

        -------

        Passes the User-Agent header so intermediate (or even backend processing) can make browser-specific customizations.

        This addresses bug SHINDIG-1781.

        https://issues.apache.org/jira/browse/SHINDIG-1781

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1340074

        Diff: https://reviews.apache.org/r/5162/diff

        Testing

        -------

        All tests pass.

        Thanks,

        Adam

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5162/#review7972 ----------------------------------------------------------- Ship it! LGTM. Having an additional MakeRequestHandlerTest that verifies that the user-agent is ferried along would be a welcome addition to the patch. Stanton On 2012-05-18 16:21:01, Adam Clarke wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5162/ ----------------------------------------------------------- (Updated 2012-05-18 16:21:01) Review request for shindig. Summary ------- Passes the User-Agent header so intermediate (or even backend processing) can make browser-specific customizations. This addresses bug SHINDIG-1781 . https://issues.apache.org/jira/browse/SHINDIG-1781 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1340074 Diff: https://reviews.apache.org/r/5162/diff Testing ------- All tests pass. Thanks, Adam
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5162/#review7975
        -----------------------------------------------------------

        LGTM as well. +1 to Stanton's test comment.

        • Dan

        On 2012-05-18 16:21:01, Adam Clarke wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5162/

        -----------------------------------------------------------

        (Updated 2012-05-18 16:21:01)

        Review request for shindig.

        Summary

        -------

        Passes the User-Agent header so intermediate (or even backend processing) can make browser-specific customizations.

        This addresses bug SHINDIG-1781.

        https://issues.apache.org/jira/browse/SHINDIG-1781

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1340074

        Diff: https://reviews.apache.org/r/5162/diff

        Testing

        -------

        All tests pass.

        Thanks,

        Adam

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5162/#review7975 ----------------------------------------------------------- LGTM as well. +1 to Stanton's test comment. Dan On 2012-05-18 16:21:01, Adam Clarke wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5162/ ----------------------------------------------------------- (Updated 2012-05-18 16:21:01) Review request for shindig. Summary ------- Passes the User-Agent header so intermediate (or even backend processing) can make browser-specific customizations. This addresses bug SHINDIG-1781 . https://issues.apache.org/jira/browse/SHINDIG-1781 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1340074 Diff: https://reviews.apache.org/r/5162/diff Testing ------- All tests pass. Thanks, Adam
        Hide
        Stanton Sievers added a comment -

        Resolved: Committed revision 1341484.

        Show
        Stanton Sievers added a comment - Resolved: Committed revision 1341484.

          People

          • Assignee:
            Unassigned
            Reporter:
            Adam Clarke
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development