Shindig
  1. Shindig
  2. SHINDIG-1769

Person API should handle "-1" as a user id

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.0
    • Fix Version/s: 2.5.0-beta2
    • Component/s: None
    • Labels:
      None

      Description

      Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.

      http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5055/
        -----------------------------------------------------------

        Review request for shindig.

        Summary
        -------

        Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.

        http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1

        This addresses bug SHINDIG-1769.
        https://issues.apache.org/jira/browse/SHINDIG-1769

        Diffs


        http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204

        Diff: https://reviews.apache.org/r/5055/diff

        Testing
        -------

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/ ----------------------------------------------------------- Review request for shindig. Summary ------- Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1 This addresses bug SHINDIG-1769 . https://issues.apache.org/jira/browse/SHINDIG-1769 Diffs http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204 Diff: https://reviews.apache.org/r/5055/diff Testing ------- Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5055/
        -----------------------------------------------------------

        (Updated 2012-05-07 20:59:08.081493)

        Review request for shindig.

        Summary
        -------

        Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.

        http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1

        This addresses bug SHINDIG-1769.
        https://issues.apache.org/jira/browse/SHINDIG-1769

        Diffs


        http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204

        Diff: https://reviews.apache.org/r/5055/diff

        Testing (updated)
        -------

        Updated unit tests

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/ ----------------------------------------------------------- (Updated 2012-05-07 20:59:08.081493) Review request for shindig. Summary ------- Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1 This addresses bug SHINDIG-1769 . https://issues.apache.org/jira/browse/SHINDIG-1769 Diffs http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204 Diff: https://reviews.apache.org/r/5055/diff Testing (updated) ------- Updated unit tests Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5055/#review7655
        -----------------------------------------------------------

        Applied the patch and played around with it. Everything looks good. Just looking for some clarification on the inline comments.

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java
        <https://reviews.apache.org/r/5055/#comment16868>

        Not sure why this had to move.

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
        <https://reviews.apache.org/r/5055/#comment16869>

        Can you set the nickname here as well? The spec seems like it wants name and nickname.

        "The value for the name and nickname fields can either be blank or set to an appropriate value such as 'Guest', 'Anonymous', etc."

        When you don't set nickname, it is not returned in the API response at all, which I don't think constitutes as "blank" per the spec language.

        • Stanton

        On 2012-05-07 20:59:08, Ryan Baxter wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5055/

        -----------------------------------------------------------

        (Updated 2012-05-07 20:59:08)

        Review request for shindig.

        Summary

        -------

        Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.

        http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1

        This addresses bug SHINDIG-1769.

        https://issues.apache.org/jira/browse/SHINDIG-1769

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204

        Diff: https://reviews.apache.org/r/5055/diff

        Testing

        -------

        Updated unit tests

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/#review7655 ----------------------------------------------------------- Applied the patch and played around with it. Everything looks good. Just looking for some clarification on the inline comments. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java < https://reviews.apache.org/r/5055/#comment16868 > Not sure why this had to move. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java < https://reviews.apache.org/r/5055/#comment16869 > Can you set the nickname here as well? The spec seems like it wants name and nickname. "The value for the name and nickname fields can either be blank or set to an appropriate value such as 'Guest', 'Anonymous', etc." When you don't set nickname, it is not returned in the API response at all, which I don't think constitutes as "blank" per the spec language. Stanton On 2012-05-07 20:59:08, Ryan Baxter wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/ ----------------------------------------------------------- (Updated 2012-05-07 20:59:08) Review request for shindig. Summary ------- Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1 This addresses bug SHINDIG-1769 . https://issues.apache.org/jira/browse/SHINDIG-1769 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204 Diff: https://reviews.apache.org/r/5055/diff Testing ------- Updated unit tests Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5055/#review7656
        -----------------------------------------------------------

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java
        <https://reviews.apache.org/r/5055/#comment16870>

        With this here is seemed to override whatever was set in the shindig.properties file. I would also like to only set it once if possible so it is less cryptic.

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
        <https://reviews.apache.org/r/5055/#comment16871>

        Yup missed the "and" in that statement I can do that.

        • Ryan

        On 2012-05-07 20:59:08, Ryan Baxter wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5055/

        -----------------------------------------------------------

        (Updated 2012-05-07 20:59:08)

        Review request for shindig.

        Summary

        -------

        Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.

        http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1

        This addresses bug SHINDIG-1769.

        https://issues.apache.org/jira/browse/SHINDIG-1769

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204

        Diff: https://reviews.apache.org/r/5055/diff

        Testing

        -------

        Updated unit tests

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/#review7656 ----------------------------------------------------------- http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java < https://reviews.apache.org/r/5055/#comment16870 > With this here is seemed to override whatever was set in the shindig.properties file. I would also like to only set it once if possible so it is less cryptic. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java < https://reviews.apache.org/r/5055/#comment16871 > Yup missed the "and" in that statement I can do that. Ryan On 2012-05-07 20:59:08, Ryan Baxter wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/ ----------------------------------------------------------- (Updated 2012-05-07 20:59:08) Review request for shindig. Summary ------- Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1 This addresses bug SHINDIG-1769 . https://issues.apache.org/jira/browse/SHINDIG-1769 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204 Diff: https://reviews.apache.org/r/5055/diff Testing ------- Updated unit tests Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-05-07 21:43:40, Ryan Baxter wrote:

        >

        @Stanton this is responses to your comments, sorry, I didn't add them as comments.

        • Ryan

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5055/#review7656
        -----------------------------------------------------------

        On 2012-05-07 20:59:08, Ryan Baxter wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5055/

        -----------------------------------------------------------

        (Updated 2012-05-07 20:59:08)

        Review request for shindig.

        Summary

        -------

        Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.

        http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1

        This addresses bug SHINDIG-1769.

        https://issues.apache.org/jira/browse/SHINDIG-1769

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204

        Diff: https://reviews.apache.org/r/5055/diff

        Testing

        -------

        Updated unit tests

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-05-07 21:43:40, Ryan Baxter wrote: > @Stanton this is responses to your comments, sorry, I didn't add them as comments. Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/#review7656 ----------------------------------------------------------- On 2012-05-07 20:59:08, Ryan Baxter wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/ ----------------------------------------------------------- (Updated 2012-05-07 20:59:08) Review request for shindig. Summary ------- Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1 This addresses bug SHINDIG-1769 . https://issues.apache.org/jira/browse/SHINDIG-1769 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204 Diff: https://reviews.apache.org/r/5055/diff Testing ------- Updated unit tests Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5055/
        -----------------------------------------------------------

        (Updated 2012-05-07 21:58:53.065194)

        Review request for shindig.

        Changes
        -------

        Nickname is also set to "Anonymous"

        Summary
        -------

        Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.

        http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1

        This addresses bug SHINDIG-1769.
        https://issues.apache.org/jira/browse/SHINDIG-1769

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204

        Diff: https://reviews.apache.org/r/5055/diff

        Testing
        -------

        Updated unit tests

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/ ----------------------------------------------------------- (Updated 2012-05-07 21:58:53.065194) Review request for shindig. Changes ------- Nickname is also set to "Anonymous" Summary ------- Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1 This addresses bug SHINDIG-1769 . https://issues.apache.org/jira/browse/SHINDIG-1769 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204 Diff: https://reviews.apache.org/r/5055/diff Testing ------- Updated unit tests Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5055/#review7660
        -----------------------------------------------------------

        Ship it!

        LGTM

        • Stanton

        On 2012-05-07 21:58:53, Ryan Baxter wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5055/

        -----------------------------------------------------------

        (Updated 2012-05-07 21:58:53)

        Review request for shindig.

        Summary

        -------

        Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.

        http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1

        This addresses bug SHINDIG-1769.

        https://issues.apache.org/jira/browse/SHINDIG-1769

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204

        Diff: https://reviews.apache.org/r/5055/diff

        Testing

        -------

        Updated unit tests

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/#review7660 ----------------------------------------------------------- Ship it! LGTM Stanton On 2012-05-07 21:58:53, Ryan Baxter wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/ ----------------------------------------------------------- (Updated 2012-05-07 21:58:53) Review request for shindig. Summary ------- Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1 This addresses bug SHINDIG-1769 . https://issues.apache.org/jira/browse/SHINDIG-1769 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204 Diff: https://reviews.apache.org/r/5055/diff Testing ------- Updated unit tests Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5055/
        -----------------------------------------------------------

        (Updated 2012-05-08 20:47:26.896328)

        Review request for shindig and Henry Saputra.

        Changes
        -------

        Added Henry.

        Henry could you take a quick look?

        Summary
        -------

        Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.

        http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1

        This addresses bug SHINDIG-1769.
        https://issues.apache.org/jira/browse/SHINDIG-1769

        Diffs


        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204
        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204

        Diff: https://reviews.apache.org/r/5055/diff

        Testing
        -------

        Updated unit tests

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/ ----------------------------------------------------------- (Updated 2012-05-08 20:47:26.896328) Review request for shindig and Henry Saputra. Changes ------- Added Henry. Henry could you take a quick look? Summary ------- Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1 This addresses bug SHINDIG-1769 . https://issues.apache.org/jira/browse/SHINDIG-1769 Diffs http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204 Diff: https://reviews.apache.org/r/5055/diff Testing ------- Updated unit tests Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5055/#review7699
        -----------------------------------------------------------

        Ship it!

        +1 Looks good to me

        • Henry

        On 2012-05-08 20:47:26, Ryan Baxter wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5055/

        -----------------------------------------------------------

        (Updated 2012-05-08 20:47:26)

        Review request for shindig and Henry Saputra.

        Summary

        -------

        Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.

        http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1

        This addresses bug SHINDIG-1769.

        https://issues.apache.org/jira/browse/SHINDIG-1769

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204

        Diff: https://reviews.apache.org/r/5055/diff

        Testing

        -------

        Updated unit tests

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/#review7699 ----------------------------------------------------------- Ship it! +1 Looks good to me Henry On 2012-05-08 20:47:26, Ryan Baxter wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/ ----------------------------------------------------------- (Updated 2012-05-08 20:47:26) Review request for shindig and Henry Saputra. Summary ------- Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1 This addresses bug SHINDIG-1769 . https://issues.apache.org/jira/browse/SHINDIG-1769 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204 Diff: https://reviews.apache.org/r/5055/diff Testing ------- Updated unit tests Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5055/#review7703
        -----------------------------------------------------------

        Committed revision 1335800

        • Ryan

        On 2012-05-08 20:47:26, Ryan Baxter wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5055/

        -----------------------------------------------------------

        (Updated 2012-05-08 20:47:26)

        Review request for shindig and Henry Saputra.

        Summary

        -------

        Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it.

        http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1

        This addresses bug SHINDIG-1769.

        https://issues.apache.org/jira/browse/SHINDIG-1769

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204

        http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204

        Diff: https://reviews.apache.org/r/5055/diff

        Testing

        -------

        Updated unit tests

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/#review7703 ----------------------------------------------------------- Committed revision 1335800 Ryan On 2012-05-08 20:47:26, Ryan Baxter wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/ ----------------------------------------------------------- (Updated 2012-05-08 20:47:26) Review request for shindig and Henry Saputra. Summary ------- Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1 This addresses bug SHINDIG-1769 . https://issues.apache.org/jira/browse/SHINDIG-1769 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204 Diff: https://reviews.apache.org/r/5055/diff Testing ------- Updated unit tests Thanks, Ryan
        Hide
        Ryan Baxter added a comment -

        Committed revision 1335800

        Show
        Ryan Baxter added a comment - Committed revision 1335800

          People

          • Assignee:
            Ryan Baxter
            Reporter:
            Ryan Baxter
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development