Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.0
    • Fix Version/s: 2.5.0-beta2
    • Component/s: Java
    • Labels:
      None

      Description

      SHINDIG-1756 sets the origination information for a request, either marking internal or adding an AnonymousSecurityToken. The exchange token request in the OAuthRequest class was missed in these updates.

        Activity

        Hide
        Stanton Sievers added a comment -

        Committed revision 1333101.

        Show
        Stanton Sievers added a comment - Committed revision 1333101.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4949/#review7471
        -----------------------------------------------------------

        Ship it!

        Committed revision 1333101.

        Please mark this review as submitted. Thanks.

        • Stanton

        On 2012-05-02 16:19:28, BrianLillie wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4949/

        -----------------------------------------------------------

        (Updated 2012-05-02 16:19:28)

        Review request for shindig.

        Summary

        -------

        Add an AnonymousSecurityToken to the OAuthRequest exchange request. This was missed in SHINDIG-1756

        This addresses bug SHINDIG-1764.

        https://issues.apache.org/jira/browse/SHINDIG-1764

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java 1331477

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/testing/FakeOAuthServiceProvider.java 1331477

        Diff: https://reviews.apache.org/r/4949/diff

        Testing

        -------

        Existing tests passed. OAuthRequestTest updated.

        Thanks,

        BrianLillie

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4949/#review7471 ----------------------------------------------------------- Ship it! Committed revision 1333101. Please mark this review as submitted. Thanks. Stanton On 2012-05-02 16:19:28, BrianLillie wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4949/ ----------------------------------------------------------- (Updated 2012-05-02 16:19:28) Review request for shindig. Summary ------- Add an AnonymousSecurityToken to the OAuthRequest exchange request. This was missed in SHINDIG-1756 This addresses bug SHINDIG-1764 . https://issues.apache.org/jira/browse/SHINDIG-1764 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java 1331477 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/testing/FakeOAuthServiceProvider.java 1331477 Diff: https://reviews.apache.org/r/4949/diff Testing ------- Existing tests passed. OAuthRequestTest updated. Thanks, BrianLillie
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4949/
        -----------------------------------------------------------

        (Updated 2012-05-02 16:19:28.366547)

        Review request for shindig.

        Summary
        -------

        Add an AnonymousSecurityToken to the OAuthRequest exchange request. This was missed in SHINDIG-1756

        This addresses bug SHINDIG-1764.
        https://issues.apache.org/jira/browse/SHINDIG-1764

        Diffs


        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java 1331477
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/testing/FakeOAuthServiceProvider.java 1331477

        Diff: https://reviews.apache.org/r/4949/diff

        Testing
        -------

        Existing tests passed. OAuthRequestTest updated.

        Thanks,

        BrianLillie

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4949/ ----------------------------------------------------------- (Updated 2012-05-02 16:19:28.366547) Review request for shindig. Summary ------- Add an AnonymousSecurityToken to the OAuthRequest exchange request. This was missed in SHINDIG-1756 This addresses bug SHINDIG-1764 . https://issues.apache.org/jira/browse/SHINDIG-1764 Diffs http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java 1331477 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/testing/FakeOAuthServiceProvider.java 1331477 Diff: https://reviews.apache.org/r/4949/diff Testing ------- Existing tests passed. OAuthRequestTest updated. Thanks, BrianLillie

          People

          • Assignee:
            Unassigned
            Reporter:
            Brian Lillie
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development