Shindig
  1. Shindig
  2. SHINDIG-1760

Add registerConextListener API for embedded experiences

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.0
    • Fix Version/s: 2.5.0-beta2
    • Component/s: None
    • Labels:
      None

      Description

      These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context.

      http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences

      http://code.google.com/p/opensocial-resources/issues/detail?id=1249

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4898/
        -----------------------------------------------------------

        Review request for shindig.

        Summary
        -------

        These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context.

        http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences

        http://code.google.com/p/opensocial-resources/issues/detail?id=1249

        This addresses bug SHINDIG-1760.
        https://issues.apache.org/jira/browse/SHINDIG-1760

        Diffs


        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1331043
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1331043
        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1331043

        Diff: https://reviews.apache.org/r/4898/diff

        Testing
        -------

        Tested with sample gadgets in the embedded experiences container.

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/ ----------------------------------------------------------- Review request for shindig. Summary ------- These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context. http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences http://code.google.com/p/opensocial-resources/issues/detail?id=1249 This addresses bug SHINDIG-1760 . https://issues.apache.org/jira/browse/SHINDIG-1760 Diffs http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1331043 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1331043 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1331043 Diff: https://reviews.apache.org/r/4898/diff Testing ------- Tested with sample gadgets in the embedded experiences container. Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4898/#review7280
        -----------------------------------------------------------

        Ship it!

        +1 LGTM

        • Henry

        On 2012-04-26 20:59:58, Ryan Baxter wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4898/

        -----------------------------------------------------------

        (Updated 2012-04-26 20:59:58)

        Review request for shindig.

        Summary

        -------

        These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context.

        http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences

        http://code.google.com/p/opensocial-resources/issues/detail?id=1249

        This addresses bug SHINDIG-1760.

        https://issues.apache.org/jira/browse/SHINDIG-1760

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1331043

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1331043

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1331043

        Diff: https://reviews.apache.org/r/4898/diff

        Testing

        -------

        Tested with sample gadgets in the embedded experiences container.

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/#review7280 ----------------------------------------------------------- Ship it! +1 LGTM Henry On 2012-04-26 20:59:58, Ryan Baxter wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/ ----------------------------------------------------------- (Updated 2012-04-26 20:59:58) Review request for shindig. Summary ------- These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context. http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences http://code.google.com/p/opensocial-resources/issues/detail?id=1249 This addresses bug SHINDIG-1760 . https://issues.apache.org/jira/browse/SHINDIG-1760 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1331043 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1331043 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1331043 Diff: https://reviews.apache.org/r/4898/diff Testing ------- Tested with sample gadgets in the embedded experiences container. Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4898/#review7297
        -----------------------------------------------------------

        Is a gadget developer not allowed to register for the EE context after the gadget has fully loaded? In your test gadgets, if you wrapped the call to gadgets.ee.registerContextListener() in a gadgets.util.registerOnLoadHandler() call, I doubt your context listeners would fire, because the config would have already been initialized. gadgets.ee.registerContextListener() should really follow an addOnLoad pattern and fire the listeners immediately if EE is initialized instead of just pushing onto an array.

        • Stanton

        On 2012-04-26 20:59:58, Ryan Baxter wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4898/

        -----------------------------------------------------------

        (Updated 2012-04-26 20:59:58)

        Review request for shindig.

        Summary

        -------

        These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context.

        http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences

        http://code.google.com/p/opensocial-resources/issues/detail?id=1249

        This addresses bug SHINDIG-1760.

        https://issues.apache.org/jira/browse/SHINDIG-1760

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1331043

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1331043

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1331043

        Diff: https://reviews.apache.org/r/4898/diff

        Testing

        -------

        Tested with sample gadgets in the embedded experiences container.

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/#review7297 ----------------------------------------------------------- Is a gadget developer not allowed to register for the EE context after the gadget has fully loaded? In your test gadgets, if you wrapped the call to gadgets.ee.registerContextListener() in a gadgets.util.registerOnLoadHandler() call, I doubt your context listeners would fire, because the config would have already been initialized. gadgets.ee.registerContextListener() should really follow an addOnLoad pattern and fire the listeners immediately if EE is initialized instead of just pushing onto an array. Stanton On 2012-04-26 20:59:58, Ryan Baxter wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/ ----------------------------------------------------------- (Updated 2012-04-26 20:59:58) Review request for shindig. Summary ------- These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context. http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences http://code.google.com/p/opensocial-resources/issues/detail?id=1249 This addresses bug SHINDIG-1760 . https://issues.apache.org/jira/browse/SHINDIG-1760 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1331043 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1331043 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1331043 Diff: https://reviews.apache.org/r/4898/diff Testing ------- Tested with sample gadgets in the embedded experiences container. Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-04-27 11:39:14, Stanton Sievers wrote:

        > Is a gadget developer not allowed to register for the EE context after the gadget has fully loaded? In your test gadgets, if you wrapped the call to gadgets.ee.registerContextListener() in a gadgets.util.registerOnLoadHandler() call, I doubt your context listeners would fire, because the config would have already been initialized. gadgets.ee.registerContextListener() should really follow an addOnLoad pattern and fire the listeners immediately if EE is initialized instead of just pushing onto an array.

        Agree I realized this last night as well.

        • Ryan

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4898/#review7297
        -----------------------------------------------------------

        On 2012-04-27 20:05:22, Ryan Baxter wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4898/

        -----------------------------------------------------------

        (Updated 2012-04-27 20:05:22)

        Review request for shindig.

        Summary

        -------

        These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context.

        http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences

        http://code.google.com/p/opensocial-resources/issues/detail?id=1249

        This addresses bug SHINDIG-1760.

        https://issues.apache.org/jira/browse/SHINDIG-1760

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1331043

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1331043

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1331043

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml 1331043

        Diff: https://reviews.apache.org/r/4898/diff

        Testing

        -------

        Tested with sample gadgets in the embedded experiences container.

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-04-27 11:39:14, Stanton Sievers wrote: > Is a gadget developer not allowed to register for the EE context after the gadget has fully loaded? In your test gadgets, if you wrapped the call to gadgets.ee.registerContextListener() in a gadgets.util.registerOnLoadHandler() call, I doubt your context listeners would fire, because the config would have already been initialized. gadgets.ee.registerContextListener() should really follow an addOnLoad pattern and fire the listeners immediately if EE is initialized instead of just pushing onto an array. Agree I realized this last night as well. Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/#review7297 ----------------------------------------------------------- On 2012-04-27 20:05:22, Ryan Baxter wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/ ----------------------------------------------------------- (Updated 2012-04-27 20:05:22) Review request for shindig. Summary ------- These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context. http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences http://code.google.com/p/opensocial-resources/issues/detail?id=1249 This addresses bug SHINDIG-1760 . https://issues.apache.org/jira/browse/SHINDIG-1760 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1331043 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1331043 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1331043 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml 1331043 Diff: https://reviews.apache.org/r/4898/diff Testing ------- Tested with sample gadgets in the embedded experiences container. Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4898/
        -----------------------------------------------------------

        (Updated 2012-04-27 20:05:22.083583)

        Review request for shindig.

        Changes
        -------

        Altered implementation to solve problem of listeners not getting notified

        Summary
        -------

        These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context.

        http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences

        http://code.google.com/p/opensocial-resources/issues/detail?id=1249

        This addresses bug SHINDIG-1760.
        https://issues.apache.org/jira/browse/SHINDIG-1760

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1331043
        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1331043
        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1331043
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml 1331043

        Diff: https://reviews.apache.org/r/4898/diff

        Testing
        -------

        Tested with sample gadgets in the embedded experiences container.

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/ ----------------------------------------------------------- (Updated 2012-04-27 20:05:22.083583) Review request for shindig. Changes ------- Altered implementation to solve problem of listeners not getting notified Summary ------- These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context. http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences http://code.google.com/p/opensocial-resources/issues/detail?id=1249 This addresses bug SHINDIG-1760 . https://issues.apache.org/jira/browse/SHINDIG-1760 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1331043 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1331043 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1331043 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml 1331043 Diff: https://reviews.apache.org/r/4898/diff Testing ------- Tested with sample gadgets in the embedded experiences container. Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4898/
        -----------------------------------------------------------

        (Updated 2012-05-01 20:11:15.214794)

        Review request for shindig.

        Changes
        -------

        Minor tweaks, making code a bit cleaner.

        Summary
        -------

        These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context.

        http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences

        http://code.google.com/p/opensocial-resources/issues/detail?id=1249

        This addresses bug SHINDIG-1760.
        https://issues.apache.org/jira/browse/SHINDIG-1760

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1332670
        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1332670
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1332670
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml 1332670

        Diff: https://reviews.apache.org/r/4898/diff

        Testing
        -------

        Tested with sample gadgets in the embedded experiences container.

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/ ----------------------------------------------------------- (Updated 2012-05-01 20:11:15.214794) Review request for shindig. Changes ------- Minor tweaks, making code a bit cleaner. Summary ------- These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context. http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences http://code.google.com/p/opensocial-resources/issues/detail?id=1249 This addresses bug SHINDIG-1760 . https://issues.apache.org/jira/browse/SHINDIG-1760 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1332670 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1332670 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1332670 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml 1332670 Diff: https://reviews.apache.org/r/4898/diff Testing ------- Tested with sample gadgets in the embedded experiences container. Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4898/#review7464
        -----------------------------------------------------------

        Ship it!

        LGTM

        • Stanton

        On 2012-05-01 20:11:15, Ryan Baxter wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4898/

        -----------------------------------------------------------

        (Updated 2012-05-01 20:11:15)

        Review request for shindig.

        Summary

        -------

        These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context.

        http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences

        http://code.google.com/p/opensocial-resources/issues/detail?id=1249

        This addresses bug SHINDIG-1760.

        https://issues.apache.org/jira/browse/SHINDIG-1760

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1332670

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1332670

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1332670

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml 1332670

        Diff: https://reviews.apache.org/r/4898/diff

        Testing

        -------

        Tested with sample gadgets in the embedded experiences container.

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/#review7464 ----------------------------------------------------------- Ship it! LGTM Stanton On 2012-05-01 20:11:15, Ryan Baxter wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/ ----------------------------------------------------------- (Updated 2012-05-01 20:11:15) Review request for shindig. Summary ------- These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context. http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences http://code.google.com/p/opensocial-resources/issues/detail?id=1249 This addresses bug SHINDIG-1760 . https://issues.apache.org/jira/browse/SHINDIG-1760 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1332670 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1332670 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1332670 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml 1332670 Diff: https://reviews.apache.org/r/4898/diff Testing ------- Tested with sample gadgets in the embedded experiences container. Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-05-02 11:40:58, Stanton Sievers wrote:

        > LGTM

        Committed

        • Ryan

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4898/#review7464
        -----------------------------------------------------------

        On 2012-05-01 20:11:15, Ryan Baxter wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4898/

        -----------------------------------------------------------

        (Updated 2012-05-01 20:11:15)

        Review request for shindig.

        Summary

        -------

        These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context.

        http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences

        http://code.google.com/p/opensocial-resources/issues/detail?id=1249

        This addresses bug SHINDIG-1760.

        https://issues.apache.org/jira/browse/SHINDIG-1760

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1332670

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1332670

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1332670

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml 1332670

        Diff: https://reviews.apache.org/r/4898/diff

        Testing

        -------

        Tested with sample gadgets in the embedded experiences container.

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-05-02 11:40:58, Stanton Sievers wrote: > LGTM Committed Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/#review7464 ----------------------------------------------------------- On 2012-05-01 20:11:15, Ryan Baxter wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/ ----------------------------------------------------------- (Updated 2012-05-01 20:11:15) Review request for shindig. Summary ------- These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context. http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences http://code.google.com/p/opensocial-resources/issues/detail?id=1249 This addresses bug SHINDIG-1760 . https://issues.apache.org/jira/browse/SHINDIG-1760 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1332670 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1332670 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1332670 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml 1332670 Diff: https://reviews.apache.org/r/4898/diff Testing ------- Tested with sample gadgets in the embedded experiences container. Thanks, Ryan

          People

          • Assignee:
            Ryan Baxter
            Reporter:
            Ryan Baxter
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development