Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.0-beta1
    • Fix Version/s: 2.5.0-beta2
    • Component/s: Java
    • Labels:
      None

      Description

      Currently the OAuth2 Consumer stores access/refresh tokens per gadget, per user.

      I have received comments that it would be convenient to allow a set of Gadgets to share a tokens per user. Improving the user experience for a group of OAuth2 dependent gadgets by not triggering additional opt-ins.

      Technically this is possible to implement with a custom OAuth2Store or OAuth2Persister but it would be nice to formalize it in shindig and the sample persistence plugin.

      When an administrator creates an OAuth2Client they can specify that the client is shared.

      "shindig_client1" :

      { "providerName" : "shindigOAuth2Provider", "type" : "confidential", "grant_type" : "code", "client_id" : "shindigClient", "client_secret" : "U78KJM98372AMGL87612993M", "sharedToken" : "true" }

      ,

      (If the value is not specified the default will be "false", keeping the current behavior.)

      In this case any gadget bound to the "shindig_client1" client will use the same access/refresh token for the user.

      Administrators should take extra care when binding sharedToken clients.

      1. 1731_20120409.patch
        9 kB
        Adam Clarke
      2. 1731_20120312.patch
        9 kB
        Adam Clarke

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4291/
        -----------------------------------------------------------

        Review request for shindig, Ryan Baxter and li xu.

        Summary
        -------

        Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true

        This addresses bug SHINDIG-1731.
        https://issues.apache.org/jira/browse/SHINDIG-1731

        Diffs


        Diff: https://reviews.apache.org/r/4291/diff

        Testing
        -------

        All test cases pass.

        Thanks,

        Adam

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ ----------------------------------------------------------- Review request for shindig, Ryan Baxter and li xu. Summary ------- Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true This addresses bug SHINDIG-1731 . https://issues.apache.org/jira/browse/SHINDIG-1731 Diffs Diff: https://reviews.apache.org/r/4291/diff Testing ------- All test cases pass. Thanks, Adam
        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ ----------------------------------------------------------- (Updated 2012-03-11 17:43:19.266570) Review request for shindig, Ryan Baxter and li xu. Summary ------- Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true This addresses bug SHINDIG-1731 . https://issues.apache.org/jira/browse/SHINDIG-1731 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1299360 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1299374 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1299360 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1299380 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1299360 Diff: https://reviews.apache.org/r/4291/diff Testing ------- All test cases pass. Thanks, Adam
        Hide
        Adam Clarke added a comment -

        Fixes '*' being too generic.

        Show
        Adam Clarke added a comment - Fixes '*' being too generic.
        Hide
        Adam Clarke added a comment -

        Fixes '*' being too general

        Show
        Adam Clarke added a comment - Fixes '*' being too general
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4291/
        -----------------------------------------------------------

        (Updated 2012-04-09 20:02:38.850154)

        Review request for shindig, Ryan Baxter and li xu.

        Changes
        -------

        Fixes problem with '*' being too generic.

        Summary
        -------

        Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true

        This addresses bug SHINDIG-1731.
        https://issues.apache.org/jira/browse/SHINDIG-1731

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1311391
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1311391
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1311391
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1311391
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1311391

        Diff: https://reviews.apache.org/r/4291/diff

        Testing
        -------

        All test cases pass.

        Thanks,

        Adam

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ ----------------------------------------------------------- (Updated 2012-04-09 20:02:38.850154) Review request for shindig, Ryan Baxter and li xu. Changes ------- Fixes problem with '*' being too generic. Summary ------- Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true This addresses bug SHINDIG-1731 . https://issues.apache.org/jira/browse/SHINDIG-1731 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1311391 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1311391 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1311391 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1311391 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1311391 Diff: https://reviews.apache.org/r/4291/diff Testing ------- All test cases pass. Thanks, Adam
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4291/#review6803
        -----------------------------------------------------------

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java
        <https://reviews.apache.org/r/4291/#comment15177>

        Just a suggestion but you might want to create a common function to create the gadgetUri as you repeat this code several times.

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java
        <https://reviews.apache.org/r/4291/#comment15172>

        Small nit, space before equals

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java
        <https://reviews.apache.org/r/4291/#comment15173>

        white space

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java
        <https://reviews.apache.org/r/4291/#comment15176>

        Makes the code easier to read if you do && here

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java
        <https://reviews.apache.org/r/4291/#comment15174>

        white space

        • Ryan

        On 2012-04-09 20:02:38, Adam Clarke wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4291/

        -----------------------------------------------------------

        (Updated 2012-04-09 20:02:38)

        Review request for shindig, Ryan Baxter and li xu.

        Summary

        -------

        Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true

        This addresses bug SHINDIG-1731.

        https://issues.apache.org/jira/browse/SHINDIG-1731

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1311391

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1311391

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1311391

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1311391

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1311391

        Diff: https://reviews.apache.org/r/4291/diff

        Testing

        -------

        All test cases pass.

        Thanks,

        Adam

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/#review6803 ----------------------------------------------------------- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java < https://reviews.apache.org/r/4291/#comment15177 > Just a suggestion but you might want to create a common function to create the gadgetUri as you repeat this code several times. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java < https://reviews.apache.org/r/4291/#comment15172 > Small nit, space before equals http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java < https://reviews.apache.org/r/4291/#comment15173 > white space http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java < https://reviews.apache.org/r/4291/#comment15176 > Makes the code easier to read if you do && here http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java < https://reviews.apache.org/r/4291/#comment15174 > white space Ryan On 2012-04-09 20:02:38, Adam Clarke wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ ----------------------------------------------------------- (Updated 2012-04-09 20:02:38) Review request for shindig, Ryan Baxter and li xu. Summary ------- Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true This addresses bug SHINDIG-1731 . https://issues.apache.org/jira/browse/SHINDIG-1731 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1311391 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1311391 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1311391 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1311391 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1311391 Diff: https://reviews.apache.org/r/4291/diff Testing ------- All test cases pass. Thanks, Adam
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4291/
        -----------------------------------------------------------

        (Updated 2012-04-10 13:39:26.956532)

        Review request for shindig, Ryan Baxter and li xu.

        Changes
        -------

        Addresses Ryan's comments.

        Summary
        -------

        Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true

        This addresses bug SHINDIG-1731.
        https://issues.apache.org/jira/browse/SHINDIG-1731

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1311401
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1311401
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1311708
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1311401
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1311401

        Diff: https://reviews.apache.org/r/4291/diff

        Testing
        -------

        All test cases pass.

        Thanks,

        Adam

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ ----------------------------------------------------------- (Updated 2012-04-10 13:39:26.956532) Review request for shindig, Ryan Baxter and li xu. Changes ------- Addresses Ryan's comments. Summary ------- Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true This addresses bug SHINDIG-1731 . https://issues.apache.org/jira/browse/SHINDIG-1731 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1311401 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1311401 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1311708 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1311401 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1311401 Diff: https://reviews.apache.org/r/4291/diff Testing ------- All test cases pass. Thanks, Adam
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4291/#review6826
        -----------------------------------------------------------

        Overall looks good. I think providing a sample client in the oauth2.json that utilizes the share token feature would be good. It would be easier for people to be aware this functionality exists

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java
        <https://reviews.apache.org/r/4291/#comment15194>

        white space

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java
        <https://reviews.apache.org/r/4291/#comment15195>

        white space

        • Ryan

        On 2012-04-10 13:39:26, Adam Clarke wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4291/

        -----------------------------------------------------------

        (Updated 2012-04-10 13:39:26)

        Review request for shindig, Ryan Baxter and li xu.

        Summary

        -------

        Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true

        This addresses bug SHINDIG-1731.

        https://issues.apache.org/jira/browse/SHINDIG-1731

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1311401

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1311401

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1311708

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1311401

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1311401

        Diff: https://reviews.apache.org/r/4291/diff

        Testing

        -------

        All test cases pass.

        Thanks,

        Adam

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/#review6826 ----------------------------------------------------------- Overall looks good. I think providing a sample client in the oauth2.json that utilizes the share token feature would be good. It would be easier for people to be aware this functionality exists http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java < https://reviews.apache.org/r/4291/#comment15194 > white space http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java < https://reviews.apache.org/r/4291/#comment15195 > white space Ryan On 2012-04-10 13:39:26, Adam Clarke wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ ----------------------------------------------------------- (Updated 2012-04-10 13:39:26) Review request for shindig, Ryan Baxter and li xu. Summary ------- Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true This addresses bug SHINDIG-1731 . https://issues.apache.org/jira/browse/SHINDIG-1731 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1311401 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1311401 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1311708 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1311401 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1311401 Diff: https://reviews.apache.org/r/4291/diff Testing ------- All test cases pass. Thanks, Adam
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4291/
        -----------------------------------------------------------

        (Updated 2012-04-10 15:00:53.484791)

        Review request for shindig, Ryan Baxter and li xu.

        Summary
        -------

        Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true

        This addresses bug SHINDIG-1731.
        https://issues.apache.org/jira/browse/SHINDIG-1731

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/config/oauth2.json 1311719
        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared1.xml PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared2.xml PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1311719
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1311719
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1311719
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1311719
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1311719

        Diff: https://reviews.apache.org/r/4291/diff

        Testing
        -------

        All test cases pass.

        Thanks,

        Adam

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ ----------------------------------------------------------- (Updated 2012-04-10 15:00:53.484791) Review request for shindig, Ryan Baxter and li xu. Summary ------- Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true This addresses bug SHINDIG-1731 . https://issues.apache.org/jira/browse/SHINDIG-1731 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/config/oauth2.json 1311719 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared1.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared2.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1311719 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1311719 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1311719 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1311719 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1311719 Diff: https://reviews.apache.org/r/4291/diff Testing ------- All test cases pass. Thanks, Adam
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4291/#review6827
        -----------------------------------------------------------

        Comments in line.

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java
        <https://reviews.apache.org/r/4291/#comment15200>

        I'm not a fan of having _gadgetUri and gadgetUri both in scope at the same time. It makes things hard to read in my opinion.

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java
        <https://reviews.apache.org/r/4291/#comment15201>

        Same as the _gadgetUri and gadgetUri comments above.

        • Stanton

        On 2012-04-10 15:00:53, Adam Clarke wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4291/

        -----------------------------------------------------------

        (Updated 2012-04-10 15:00:53)

        Review request for shindig, Ryan Baxter and li xu.

        Summary

        -------

        Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true

        This addresses bug SHINDIG-1731.

        https://issues.apache.org/jira/browse/SHINDIG-1731

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/config/oauth2.json 1311719

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared1.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared2.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1311719

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1311719

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1311719

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1311719

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1311719

        Diff: https://reviews.apache.org/r/4291/diff

        Testing

        -------

        All test cases pass.

        Thanks,

        Adam

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/#review6827 ----------------------------------------------------------- Comments in line. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java < https://reviews.apache.org/r/4291/#comment15200 > I'm not a fan of having _gadgetUri and gadgetUri both in scope at the same time. It makes things hard to read in my opinion. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java < https://reviews.apache.org/r/4291/#comment15201 > Same as the _gadgetUri and gadgetUri comments above. Stanton On 2012-04-10 15:00:53, Adam Clarke wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ ----------------------------------------------------------- (Updated 2012-04-10 15:00:53) Review request for shindig, Ryan Baxter and li xu. Summary ------- Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true This addresses bug SHINDIG-1731 . https://issues.apache.org/jira/browse/SHINDIG-1731 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/config/oauth2.json 1311719 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared1.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared2.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1311719 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1311719 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1311719 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1311719 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1311719 Diff: https://reviews.apache.org/r/4291/diff Testing ------- All test cases pass. Thanks, Adam
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4291/
        -----------------------------------------------------------

        (Updated 2012-04-11 14:55:54.729162)

        Review request for shindig, Ryan Baxter and li xu.

        Changes
        -------

        addresses feedback

        Summary
        -------

        Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true

        This addresses bug SHINDIG-1731.
        https://issues.apache.org/jira/browse/SHINDIG-1731

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/config/oauth2.json 1324775
        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared1.xml PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared2.xml PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1324775
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1324775
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1324775
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1324775
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1324775

        Diff: https://reviews.apache.org/r/4291/diff

        Testing
        -------

        All test cases pass.

        Thanks,

        Adam

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ ----------------------------------------------------------- (Updated 2012-04-11 14:55:54.729162) Review request for shindig, Ryan Baxter and li xu. Changes ------- addresses feedback Summary ------- Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true This addresses bug SHINDIG-1731 . https://issues.apache.org/jira/browse/SHINDIG-1731 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/config/oauth2.json 1324775 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared1.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared2.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1324775 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1324775 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1324775 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1324775 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1324775 Diff: https://reviews.apache.org/r/4291/diff Testing ------- All test cases pass. Thanks, Adam
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4291/#review6874
        -----------------------------------------------------------

        Ship it!

        LGTM Adam! If no one else has any feedback I will commit this tomorrow.

        • Ryan

        On 2012-04-11 14:55:54, Adam Clarke wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4291/

        -----------------------------------------------------------

        (Updated 2012-04-11 14:55:54)

        Review request for shindig, Ryan Baxter and li xu.

        Summary

        -------

        Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true

        This addresses bug SHINDIG-1731.

        https://issues.apache.org/jira/browse/SHINDIG-1731

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/config/oauth2.json 1324775

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared1.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared2.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1324775

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1324775

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1324775

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1324775

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1324775

        Diff: https://reviews.apache.org/r/4291/diff

        Testing

        -------

        All test cases pass.

        Thanks,

        Adam

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/#review6874 ----------------------------------------------------------- Ship it! LGTM Adam! If no one else has any feedback I will commit this tomorrow. Ryan On 2012-04-11 14:55:54, Adam Clarke wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ ----------------------------------------------------------- (Updated 2012-04-11 14:55:54) Review request for shindig, Ryan Baxter and li xu. Summary ------- Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true This addresses bug SHINDIG-1731 . https://issues.apache.org/jira/browse/SHINDIG-1731 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/config/oauth2.json 1324775 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared1.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared2.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1324775 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1324775 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1324775 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1324775 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1324775 Diff: https://reviews.apache.org/r/4291/diff Testing ------- All test cases pass. Thanks, Adam
        Hide
        Ryan Baxter added a comment -

        Committed revision 1326799

        Show
        Ryan Baxter added a comment - Committed revision 1326799
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-04-12 12:14:33, Ryan Baxter wrote:

        > LGTM Adam! If no one else has any feedback I will commit this tomorrow.

        Committed revision 1326799

        • Ryan

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4291/#review6874
        -----------------------------------------------------------

        On 2012-04-11 14:55:54, Adam Clarke wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4291/

        -----------------------------------------------------------

        (Updated 2012-04-11 14:55:54)

        Review request for shindig, Ryan Baxter and li xu.

        Summary

        -------

        Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true

        This addresses bug SHINDIG-1731.

        https://issues.apache.org/jira/browse/SHINDIG-1731

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/config/oauth2.json 1324775

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared1.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared2.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1324775

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1324775

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1324775

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1324775

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1324775

        Diff: https://reviews.apache.org/r/4291/diff

        Testing

        -------

        All test cases pass.

        Thanks,

        Adam

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-04-12 12:14:33, Ryan Baxter wrote: > LGTM Adam! If no one else has any feedback I will commit this tomorrow. Committed revision 1326799 Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/#review6874 ----------------------------------------------------------- On 2012-04-11 14:55:54, Adam Clarke wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ ----------------------------------------------------------- (Updated 2012-04-11 14:55:54) Review request for shindig, Ryan Baxter and li xu. Summary ------- Allows multiple gadgets to share a token by binding to an OAuth2Client with sharedToken=true This addresses bug SHINDIG-1731 . https://issues.apache.org/jira/browse/SHINDIG-1731 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/config/oauth2.json 1324775 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared1.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared2.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1324775 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java 1324775 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java 1324775 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java 1324775 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java 1324775 Diff: https://reviews.apache.org/r/4291/diff Testing ------- All test cases pass. Thanks, Adam

          People

          • Assignee:
            Unassigned
            Reporter:
            Adam Clarke
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development